fix MC-242809 #421
Merged
fix MC-242809 #421
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsDev/mc-242809 # Conflicts: # PATCHED.md
# Conflicts: # PATCHED.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.mojang.com/browse/MC/issues/MC-242809
it is worth noting that this bug is labeled as "Works as Intended", however I would argue this fix can still be incredibly useful for many people. I have seen many people trying to copy paste server IPs from other people and accidentally copying in a whitespace and getting confused on why they are unable to connect. IPs should never have spaces, so trimming them should be perfectly safe.
Additionally, debugify already fixes WAI bugs, notably the no telemetry fix.
I understand if you decide to close this but to me it seems a useful bugfix and quite uninvasive. Best case someone doesn't have to see an unhelpful error message for a typo, worst case no one notices this anyways.