fix MC-271899 #419
Open
fix MC-271899 #419
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isXander
requested changes
Jul 20, 2025
| private Map<Block, List<StructureTemplate.StructureBlockInfo>> cache; | ||
|
|
||
| // Use a thread-safe Concurrent Map instead | ||
| @Inject(method = "<init>", at = @At(value = "TAIL")) |
There was a problem hiding this comment.
you can just reassign the shadowed field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.mojang.com/browse/MC/issues/MC-271899
this stems from a neoforge report. it seems its incredibly rare to reproduce but their patch (as described in the mojira bug report) should be enough to patch it. i'm pretty sure this is how you correctly implement a patch like this using mixin, but not 100% on it.
i was previously trying to wrapoperation/modifyexpression it and noticed i was nuking structures entirely. with this current mixin it appears that structures generate fine, so I'm PRing it