Skip to content

Post-Quantum (PQ) and Post-Quantum/Traditional (PQ/T) hybrid signatures for VCs #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 246 commits into
base: main
Choose a base branch
from

Conversation

AleCla97
Copy link

@AleCla97 AleCla97 commented Mar 31, 2025

Description of change

Integration of Post-Quantum (PQ) and Post-Quantum/Traditional (PQ/T) hybrid signatures for VCs

  • New features: pqc for PQ related code, hybrid for hybrid related code, pqc-liboqs for the pq signatures implementation based on liboqs, hybrid-liboqs for the hybrid signatures implementation, based on this draft
  • JwkStoragePQ: Extension of the JwkStorage for pq keys and Memstore implementation
  • Algorithm Key Pair (AKP), new Jwktype for PQ JWKs based on ML-DSA for JOSE and COSE
    draft
  • CompositeAlgId: Hybrid keytype MLDSA44/65-ED25519
  • DID JWK extension: create a new DID JWK with traditional, pq, hybrid and zk keys
  • DIDCompositeJWK, did method for hybrid keys and his relative resolver
  • JwtCredentialValidatorHybrid and JwtPresentationValidatorHybrid, hybrid signature validators
  • PQCJwsVerifier, verifier for PQ signatures with an implementation based on liboqs
  • New examples: pq and hybrid
  • Wasm: bindings of the new functions
  • Wasm: new examples: pq and hybrid
  • Wasm: JwkPqMemStore and PQJwsVerifier implementation of JwkStorage and IJwsVerifier with noble post quantum for ML-DSA

Other changes

  • Bump zkryptium and json proof token version to match the latest BBS and JPT drafts

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

  • cargo test --release to see that there were no incompatibilities.
  • the new features were tested through the new pq and hybrid tests( both rust and wasm.)
  • the update of zkryptium and json proof token was also tested by running the zkp tests

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

result.into()
WasmJwkStorage::_generate_pq_key(self, key_type.into(), alg.name().to_owned())
.await
.into_serde()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left into_serde even though it is deprecated because serde_wasm_bindgen::from_value requires the trait T: serde::de::DeserializeOwned but JwkGenOutput does not implement it

@AleCla97 AleCla97 requested a review from UMR1352 June 20, 2025 14:39
@UMR1352
Copy link
Contributor

UMR1352 commented Jul 15, 2025

Hey @AleCla97, sorry for the long silence. I finally have the time to get this PR a to a merge-able state. Would you guys give me access to your fork? That way I can directly push commits there to fix the merge conflicts and adapt you code to the latest version of the library

@AleCla97
Copy link
Author

yeah sure :)

I have added you. Let me know if there are any problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

7 participants