Skip to content

[SYCL][E2E] Drop XFAIL and UNSUPPORTED for accelerator #19228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sycl/test-e2e/AddressCast/dynamic_address_cast.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
//===----------------------------------------------------------------------===//

// Issue with OpenCL CPU runtime implementation of OpGenericCastToPtrExplicit
// FPGA emulator affected by same issue as OpenCL CPU runtime
// UNSUPPORTED: cpu, accelerator
// UNSUPPORTED: cpu
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 1 addition & 2 deletions sycl/test-e2e/AddressCast/khr_dynamic_addrspace_cast.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
//===----------------------------------------------------------------------===//

// Issue with OpenCL CPU runtime implementation of OpGenericCastToPtrExplicit
// FPGA emulator affected by same issue as OpenCL CPU runtime
// UNSUPPORTED: cpu, accelerator
// UNSUPPORTED: cpu
// UNSUPPORTED-TRACKER: CMPLRLLVM-37365
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// REQUIRES: target-spir, opencl, opencl_icd, aspect-usm_shared_allocations
// RUN: %{build} %opencl_lib -fno-sycl-dead-args-optimization -o %t.out
// RUN: %{run} %t.out
// XFAIL: accelerator
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16914
//
#include <sycl/backend.hpp>
#include <sycl/detail/cl.h>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL: accelerator
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/17209

#include <sycl/detail/core.hpp>
#include <sycl/detail/info_desc_helpers.hpp>
#include <sycl/kernel.hpp>
Expand Down
5 changes: 0 additions & 5 deletions sycl/test-e2e/Graph/Explicit/spec_constants_handler_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Intended - The following limitation is not restricted to Sycl-Graph
// but comes from the orignal test : `SpecConstants/2020/handler-api.cpp`
// FIXME: ACC devices use emulation path, which is not yet supported
// UNSUPPORTED: accelerator

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/spec_constants_handler_api.cpp"
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

// Intended - The following limitation is not restricted to Sycl-Graph
// but comes from the orignal test : `SpecConstants/2020/kernel-bundle-api.cpp`
// FIXME: ACC devices use emulation path, which is not yet supported
// UNSUPPORTED: accelerator
// UNSUPPORTED: hip

#define GRAPH_E2E_EXPLICIT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Intended - The following limitation is not restricted to Sycl-Graph
// but comes from the orignal test : `SpecConstants/2020/handler-api.cpp`
// FIXME: ACC devices use emulation path, which is not yet supported
// UNSUPPORTED: accelerator

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/spec_constants_handler_api.cpp"
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

// Intended - The following limitation is not restricted to Sycl-Graph
// but comes from the orignal test : `SpecConstants/2020/kernel-bundle-api.cpp`
// FIXME: ACC devices use emulation path, which is not yet supported
// UNSUPPORTED: accelerator
// UNSUPPORTED: hip

#define GRAPH_E2E_RECORD_REPLAY
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/GroupAlgorithm/root_group.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Fails with opencl non-cpu, enable when fixed.
// XFAIL: (opencl && !cpu && !accelerator)
// XFAIL: (opencl && !cpu)
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14641

// RUN: %{build} -I . -o %t.out %if target-nvidia %{ -Xsycl-target-backend=nvptx64-nvidia-cuda --cuda-gpu-arch=sm_70 %}
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/opencl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//===----------------------------------------------------------------------===//

// REQUIRES: ocloc && (opencl || level_zero)
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test the kernel_compiler with OpenCL source.
// RUN: %{build} -o %t.out
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/opencl_cache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//===----------------------------------------------------------------------===//

// REQUIRES: ocloc && (opencl || level_zero)
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test the kernel_compiler with OpenCL source.
// RUN: %{build} -o %t.out
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/opencl_cache_eviction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// Tests on-disk cache and eviction with kernel_compiler.

// REQUIRES: ocloc && (opencl || level_zero)
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: kernel_compiler is not available for accelerator
// devices.

// -- Test the kernel_compiler with OpenCL source.
// RUN: %{build} -o %t.out
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/opencl_flags.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// REQUIRES: ocloc && (opencl || level_zero)
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/opencl_multi_device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//===----------------------------------------------------------------------===//

// REQUIRES: (opencl || level_zero) && ocloc
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 %{run} %t.out
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{l0_leak_check} %{run} %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_basic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{l0_leak_check} %{run} %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_cache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// DEFINE: %{cache_vars} = env SYCL_CACHE_PERSISTENT=1 SYCL_CACHE_TRACE=7 SYCL_CACHE_DIR=%t/cache_dir
// DEFINE: %{max_cache_size} = SYCL_CACHE_MAX_SIZE=30000
// RUN: %{build} -o %t.out
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_cache_pm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test the kernel_compiler with SYCL source.
// RUN: %{build} -o %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_context_error.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{run-unfiltered-devices} %t.out

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/sycl_device_globals.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator, opencl && gpu
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.
// UNSUPPORTED: opencl && gpu
// UNSUPPORTED-TRACKER: GSD-4287

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_export_registration.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: (opencl || level_zero)

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// Note linking is not supported on CUDA/HIP.

// -- Test for a case where a kernel bundle is built that exports a symbol and
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/KernelCompiler/sycl_include_paths.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
//===----------------------------------------------------------------------===//

// REQUIRES: aspect-usm_device_allocations
// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{run} %t.out %S | FileCheck %s --check-prefixes=CHECK,CHECK-NOCWD
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_join.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{run} %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{l0_leak_check} %{run} %t.out
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_lifetimes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} env SYCL_UR_TRACE=-1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_link.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test for a simple linking case with source files compiled from SYCL source
// -- at runtime.

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_link_common_dep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// Note linking is not supported on CUDA/HIP.

// -- Test for linking where two kernels use the same imported symbols.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// Note linking is not supported on CUDA/HIP.

// -- Test for linking where two kernels use the same imported symbols, but one
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_link_export_conflict.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// Note linking is not supported on CUDA/HIP.

// -- Test for a case where a kernel bundle with an exported symbol is compiled
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_link_kernel_conflict.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// Note linking is not supported on CUDA/HIP.

// -- Test for the linking of two kernels with conflicting definitions of
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_namespaces.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{l0_leak_check} %{run} %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_overload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

// REQUIRES: aspect-usm_device_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{l0_leak_check} %{run} %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/KernelCompiler/sycl_time_trace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: SYCL-RTC is not available for accelerator devices

// RUN: %{build} -o %t.out
// RUN: %if hip %{ env SYCL_JIT_AMDGCN_PTX_TARGET_CPU=%{amd_arch} %} %{run} %t.out | FileCheck %s

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/NewOffloadDriver/lit.local.cfg
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import platform

config.unsupported_features += ['accelerator']

config.substitutions.append(
("%{embed-ir}", "%if target-amd || target-nvidia %{ -fsycl-embed-ir %}")
)
4 changes: 0 additions & 4 deletions sycl/test-e2e/ProfilingTag/in_order_profiling_queue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
// UNSUPPORTED: cuda
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/14053

// FPGA emulator seems to return unexpected start time for the fallback barrier.
// UNSUPPORTED: accelerator
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/14315

#include "common.hpp"

int main() {
Expand Down
4 changes: 0 additions & 4 deletions sycl/test-e2e/ProfilingTag/profiling_queue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
// UNSUPPORTED: hip
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/12904

// FPGA emulator seems to return unexpected start time for the fallback barrier.
// UNSUPPORTED: accelerator
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/14315

// Flaky on CUDA
// UNSUPPORTED: cuda
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/14053
Expand Down
9 changes: 4 additions & 5 deletions sycl/test-e2e/Regression/get_subgroup_sizes.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// UNSUPPORTED: accelerator
// TODO: FPGAs currently report `sub_group_sizes` as non-empty list,
// despite not having extension `cl_intel_required_subgroup_size`
// UNSUPPORTED: cuda || hip
// TODO: Similar issue to FPGAs
// REQUIRES: opencl || level_zero
// Test assumes that the SYCL 2020 deprecated info::device::extensions query
// returns a string with cl_intel_required_subgroup_size, while that is only
// really guaranteed by OpenCL. Coincidentally it also works this way for L0.

// RUN: %{build} -Wno-error=deprecated-declarations -o %t.out
// RUN: %{run} %t.out
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/SYCLBIN/link_rtc_input.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test for linking where one kernel is runtime-compiled and one is compiled
// -- to SYCLBIN.

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/SYCLBIN/link_rtc_object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// REQUIRES: (opencl || level_zero)
// REQUIRES: aspect-usm_shared_allocations

// UNSUPPORTED: accelerator
// UNSUPPORTED-INTENDED: while accelerator is AoT only, this cannot run there.

// -- Test for linking where one kernel is runtime-compiled and one is compiled
// -- to SYCLBIN.

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/XPTI/buffer/multiple_queues.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: xptifw, opencl, (cpu || accelerator)
// REQUIRES: xptifw, opencl, cpu
// RUN: %build_collector
// RUN: %{build} -o %t.out
// RUN: env XPTI_TRACE_ENABLE=1 XPTI_FRAMEWORK_DISPATCHER=%xptifw_dispatcher XPTI_SUBSCRIBERS=%t_collector.dll %{run} %t.out | FileCheck %s
Expand Down
Loading