Skip to content

[UR] Fix creation of context with parent device and its sub-devices #19223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

againull
Copy link
Contributor

This use case seems to be allowed. For example, according to: https://intel.github.io/llvm/MultiTileCardWithLevelZero.html#context "Both root-devices and sub-devices can be within single context, but they all should be of the same SYCL platform."

Before change CollectDevicesAndSubDevices was resulting in duplicate devices being returned which leads to an error in

if (!descToPoolMap.try_emplace(desc, std::move(hPool)).second) {
UR_LOG(ERR, "Pool for pool descriptor: {}, already exists", desc);
because of the duplicate pool descriptors.

This use case seems to be allowed. For example, according to:
https://intel.github.io/llvm/MultiTileCardWithLevelZero.html#context
"Both root-devices and sub-devices can be within single context, but they all should be of the same SYCL platform."
@againull againull requested review from a team as code owners June 30, 2025 22:11
@againull againull temporarily deployed to WindowsCILock July 1, 2025 01:29 — with GitHub Actions Inactive
@againull againull temporarily deployed to WindowsCILock July 1, 2025 03:57 — with GitHub Actions Inactive
@againull againull merged commit 4fd438a into intel:sycl Jul 2, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants