Fix for saving (respectively retrieving) values #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am open to merge this into my repository so this is downloadable from the Arduino IDE. |
|
Hi, yes, would be nice. Thanks. |
|
You can make a PR with your changes to my repo and I'll look over them |
I did. It's a bunch of changes in one. Let me know, whether I should split it, if only a subset is of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the adaption for ESP32 and newer JSON lib, but had some trouble in retrieving the values from the settings. To me it looks necessary to pass the JsonDocument as reference for serialize method.
For consistency I adopted the deserialize as well.
I noticed the problem while saving. The items passed to be serialized where not included in the JsonDocument. Not sure whether compiler settings might influence this. I'm using plain Arduino IDE 1.8.10 plus with integrated espressif tool chain.