Skip to content

Fix for saving (respectively retrieving) values #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gerdlanger
Copy link

I like the adaption for ESP32 and newer JSON lib, but had some trouble in retrieving the values from the settings. To me it looks necessary to pass the JsonDocument as reference for serialize method.
For consistency I adopted the deserialize as well.

I noticed the problem while saving. The items passed to be serialized where not included in the JsonDocument. Not sure whether compiler settings might influence this. I'm using plain Arduino IDE 1.8.10 plus with integrated espressif tool chain.

@Tvde1
Copy link

Tvde1 commented Jan 8, 2020

Hi, I am open to merge this into my repository so this is downloadable from the Arduino IDE.

@gerdlanger
Copy link
Author

Hi, yes, would be nice. Thanks.

@Tvde1
Copy link

Tvde1 commented Jan 12, 2020

You can make a PR with your changes to my repo and I'll look over them

@gerdlanger
Copy link
Author

You can make a PR with your changes to my repo and I'll look over them

I did. It's a bunch of changes in one. Let me know, whether I should split it, if only a subset is of interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants