Convert module constants to IntEnum #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Incomplete draft for now until it is decided whether this is preferrable)
This PR converts some of the module constants, which come from the C
enums, to properIntEnums. That arguably makes the API cleaner and easier to use.Instead of
it would be
and one gets to enjoy better code completion due to better type hints.
This is a breaking change unless we leave the module constants but set them to the values of the
IntEnums. Imo it's fine as long as the version is bumped accordingly so I'd like to just clean this up and not leave the module constants.