Skip to content

Add workflow for releasing gem #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

tsuzuki-takaaki
Copy link
Contributor

@tsuzuki-takaaki tsuzuki-takaaki commented Jun 16, 2025

What

Why

  • We always execute the release command locally

Refs

Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@tsuzuki-takaaki tsuzuki-takaaki self-assigned this Jun 16, 2025
@tsuzuki-takaaki tsuzuki-takaaki force-pushed the create-workflow-for-releasing-gem branch from b51ded1 to 0845dcd Compare June 16, 2025 07:17
@tsuzuki-takaaki tsuzuki-takaaki marked this pull request as ready for review June 16, 2025 07:23
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 07:23
@tsuzuki-takaaki tsuzuki-takaaki requested a review from a team as a code owner June 16, 2025 07:23
@tsuzuki-takaaki tsuzuki-takaaki requested review from kimkim0814 and removed request for a team June 16, 2025 07:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new GitHub Actions workflow to automate gem releases to RubyGems.org.

  • Introduces a manual workflow_dispatch trigger for releases
  • Checks out code, sets up Ruby 3.4.4 with bundler cache, and runs rubygems/release-gem
  • Configures necessary permissions and environment
Comments suppressed due to low confidence (2)

.github/workflows/release.yml:17

  • Add with: fetch-depth: 0 to the actions/checkout step to ensure the full Git history (including tags) is fetched, which is required for release-gem to detect and manage version tags correctly.
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/release.yml:17

  • [nitpick] Consider pinning to a stable version tag (e.g., actions/checkout@v4) instead of a full commit SHA for better readability and simpler updates.
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

kimkim0814
kimkim0814 previously approved these changes Jun 17, 2025
Copy link
Member

@kimkim0814 kimkim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits 以外は良さそうです

LGTM!

@tsuzuki-takaaki tsuzuki-takaaki force-pushed the create-workflow-for-releasing-gem branch from f84b599 to fbc6139 Compare June 17, 2025 02:21
@kimkim0814 kimkim0814 merged commit a2e49ba into master Jun 17, 2025
8 checks passed
@kimkim0814 kimkim0814 deleted the create-workflow-for-releasing-gem branch June 17, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants