Skip to content

Custom Protocol Support For Notification itself #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ASAJacob
Copy link

This allows for a custom protocol to be called when the Notification itself is called. For example could be used to get around Toast Notifications ability to be dismissed. If the user clicks the notification you could trigger the notification to be displayed again. Also useful to perform the same action as one of the protocols assigned to the action buttons. Currently sets the default protocol to open Microsoft edge to demonstrate the feature in all the example config files. If no custom protocol is set I have not seen any negative effects.

This allows for a custom protocol to be called when the Notification itself is called. For example could be used to get around Toast Notifications ability to be dismissed. If the user clicks the notification you could trigger the notification to be displayed again. Also useful to perform the same action as one of the protocols assigned to the action buttons.
@ASAJacob
Copy link
Author

Sorry for creating 2 other failed PRs. Not sure what the deal was with Github's hub CLI tool not playing nicely with a non-standard fork of the repo. Ideally would love to get this merged sooner rather than later. Been doing a lot of work to perform some custom Windows Upgrades using your script but ended up having to make heavy modifications. I have been having to run everything as VBS to make it invisible to the user since I am running the script in a System Context. Not sure if there is any interest to make it worth while to merge in but I can also open another PR that makes the any custom protocol run hidden using VBS. I also had a question about the implementation of the way your script Run as the logged in User. I was never able to completely hide the toast notification generation from the end user using your script since I am initially calling from a system context. I ended up having to use the RunAsUser powershell module and then called your script from Wscript and VBS. Not sure if this is normal behavior and/or if you would like some documentation done on the method I am using to completely hide the generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant