-
Notifications
You must be signed in to change notification settings - Fork 21
Shearing box self gravity #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
6f57c50
to
46512dd
Compare
a few comments on the fly:
|
For the test: I tried it on A100 (no MPI) and :
|
Some of the variables in the test were not initialised, so this can certainly lead to different results. In addition, the test provided is not great (as indicated by the large error of testidefix.py), as it seems like it assumes perfect advection of the potential by the shear, but at the same time, density changes because of sound wave propagation, and there is this weird VX1 that is I believe a residue from the hydro shearing wave test (is it?). This should really be cleaned up. Can't we have a shearing-box+self-gravity following a self-gravitating shearing wave? Would make more sense IMHO. |
I added a test for the shearing wave. I mostly copied the setup section 4 of from Paardekooper 2012. But there is a key difference explaining the difference with this test and their Fig 3: This setup is purely 2D, not with a razor thin disc. This is why the ODE in the python script is different from their eq 89 (there is a factor 2/k different) and the produced result is not the same. On my side it passes with MPI and on a single A100. I can remove the test I first implemented, as the shearing wave is a better one. This test also passes with no self gravity, but I did not include that version, to avoid redundancy with the already exist shearing box test. Let me know if you think it should be included as well. |
e8ece7c
to
29cbeae
Compare
Rebased to have #346 |
This adds the shearing box boundary conditions for the self-gravity potential.
Some notes that need to be discussed:
laplacian.cpp
line 43 theisPeriodic
variable is set but seems to never be used