update ember to 3.28 and bump dependencies #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @skaterdav85, do you have time to check this ? |
|
@skaterdav85 up |
|
@Henridv @andrewpye @sovietspaceship2 any one can check this ? |
|
Hi @mostafa-sakhiri! The contributors you've tagged have each only contributed one small PR to this addon or are no longer active on GitHub. It looks like @iamdtang has been mostly inactive on here for a couple of months, but any decision on how to proceed here is his to make 🤷 |
added 4 commits
August 8, 2022 10:08
/home/ctjhoa/concord/ember-changeset-conditional-validations/addon/validators/sometimes.js 29:50 error Do not access Object.prototype method 'hasOwnProperty' from target object no-prototype-builtins 36:23 error Do not access Object.prototype method 'hasOwnProperty' from target object no-prototype-builtins
Okay, thank you @andrewpye |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated ember to 3.28 and bumped dependencies.