Rename .tt-dropdown-menu to .tt-menu #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename .tt-dropdown-menu to .tt-menu for compatibility with typeahead.js v0.11.1
|
Overlooked, that there are tests to adjust. |
|
Is this resolved now? I don't see these changes merged yet. If there are still tests to adjust why is the issue closed? |
|
Looks like this is a more comprehensive version of the earlier pull request #23 , but it hasn't been merged because there are still tests to fix. Until this is merged, a workaround is just to tell typeahead.js to use the old class name: |
rtyley
added a commit
to rtyley/submitgit
that referenced
this pull request
Jun 21, 2015
Note the workaround for `typeahead.js-bootstrap3.less` not having quite updated to cope with a class-name change in `typeahead.js` v0.11.1 (made the suggestions background-transparent) - just tell typeahead.js to use the old class name: hyspace/typeahead.js-bootstrap3.less#24 (comment)
rtyley
added a commit
to rtyley/submitgit
that referenced
this pull request
Jun 27, 2015
Note the workaround for `typeahead.js-bootstrap3.less` not having quite updated to cope with a class-name change in `typeahead.js` v0.11.1 (made the suggestions background-transparent) - just tell typeahead.js to use the old class name: hyspace/typeahead.js-bootstrap3.less#24 (comment)
rtyley
added a commit
to rtyley/submitgit
that referenced
this pull request
Jun 30, 2015
Typeahead for identifying message-ids in a human-readable way Particularly like linking back to the Gmane article... lotsa jquery Add bootstrap-3-specific styling to the typeahead.js stuff Note the workaround for `typeahead.js-bootstrap3.less` not having quite updated to cope with a class-name change in `typeahead.js` v0.11.1 (made the suggestions background-transparent) - just tell typeahead.js to use the old class name: hyspace/typeahead.js-bootstrap3.less#24 (comment)
rtyley
added a commit
to rtyley/submitgit
that referenced
this pull request
Jun 30, 2015
Typeahead for identifying message-ids in a human-readable way Particularly like linking back to the Gmane article... lotsa jquery Add bootstrap-3-specific styling to the typeahead.js stuff Note the workaround for `typeahead.js-bootstrap3.less` not having quite updated to cope with a class-name change in `typeahead.js` v0.11.1 (made the suggestions background-transparent) - just tell typeahead.js to use the old class name: hyspace/typeahead.js-bootstrap3.less#24 (comment)
rtyley
added a commit
to rtyley/submitgit
that referenced
this pull request
Jun 30, 2015
Using typeahead.js for confirming the message-id - we call into the Gmane & MARC mail archives to show a summary of the message to the user. Added bootstrap-3-specific styling to the typeahead.js stuff. Note the workaround for `typeahead.js-bootstrap3.less` not having quite updated to cope with a class-name change in `typeahead.js` v0.11.1 (made the suggestions background-transparent) - just tell typeahead.js to use the old class name: hyspace/typeahead.js-bootstrap3.less#24 (comment) lotsa jquery, coding like it's 2010.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename .tt-dropdown-menu to .tt-menu for compatibility with typeahead.js v0.11.1, like mentioned in #22