chore: Update ezeth to prevent inbound to blast #930
Conversation
🦋 Changeset detectedLatest commit: aff1bbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ltyu
changed the title
Check Warp Deploy Summary
Last updated: 2025-06-23 15:38:04 UTC |
📝 WalkthroughWalkthroughThe updates restructure deployment YAML configurations for multiple blockchain domains by introducing domain-based routing hooks, removing protocol fee fields, and simplifying interchain security modules for the "blast" domain. Additionally, protocol fee values are adjusted for specific domains, and a new changeset records a minor version update for the registry package. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeploymentConfig
participant DomainRoutingHook
participant InterchainSecurityModule
User->>DeploymentConfig: Initiate deployment
DeploymentConfig->>DomainRoutingHook: Assign hooks via domains mapping
DeploymentConfig->>InterchainSecurityModule: Configure ISM (simplified for blast)
DomainRoutingHook-->>DeploymentConfig: Hooks ready per domain
InterchainSecurityModule-->>DeploymentConfig: ISM ready per domain
DeploymentConfig-->>User: Deployment complete
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
deployments/warp_routes/EZETHSTAGE/renzo-stage-deploy.yaml (4)
252-269: Duplicate: Consolidate hook definitions for Base.
Same domain-based hook mapping pattern applied underbase.hook.hooks. No changes beyond address validation.
499-517: Duplicate: Consolidate hook definitions for Berachain.
Pattern repeated identically forberachain.hook.hooks. Ensure consistency of the address and owner fields.
761-778: Duplicate: Consolidate hook definitions for BSC.
Uniform domainRoutingHook mapping applied. No additional feedback.
1008-1025: Duplicate: Consolidate hook definitions for Ethereum.
Consistent application of the domainRoutingHook pattern. Address and owner checks recommended.
🧹 Nitpick comments (1)
.changeset/lucky-badgers-care.md (1)
5-5: Consider refining the summary phrasing
We generally use imperative tone in changeset summaries. For example:
“Prevent inbound traffic to the blast component in EZETH prod and stage configs while allowing outbound.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.changeset/lucky-badgers-care.md(1 hunks)deployments/warp_routes/EZETH/renzo-prod-deploy.yaml(16 hunks)deployments/warp_routes/EZETHSTAGE/renzo-stage-deploy.yaml(16 hunks)deployments/warp_routes/PZETHSTAGE/berachain-ethereum-swell-unichain-zircuit-deploy.yaml(4 hunks)deployments/warp_routes/REZSTAGING/base-ethereum-unichain-deploy.yaml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: rpc-health-mainnet
- GitHub Check: rpc-health-testnet
- GitHub Check: test
- GitHub Check: check-warp-deploy
🔇 Additional comments (19)
deployments/warp_routes/PZETHSTAGE/berachain-ethereum-swell-unichain-zircuit-deploy.yaml (4)
90-90: Approve EthereumprotocolFeeupdate.The new value (
158365200000000) aligns with the updated fee schedule.
171-171: Approve SwellprotocolFeeupdate.The new value (
158365200000000) matches the intended configuration.
252-252: Approve UnichainprotocolFeeupdate.The updated fee (
192111100000000) is correct per specifications.
333-333: Approve ZircuitprotocolFeeupdate.The change (
158365200000000) is consistent with the other domains.deployments/warp_routes/REZSTAGING/base-ethereum-unichain-deploy.yaml (3)
9-9: Approve BaseprotocolFeeupdate.Updated to
158365200000000to match the revised fee structure.
62-62: Approve EthereumprotocolFeeupdate.New fee (
158365200000000) aligns with the cross-domain fee recalibration.
115-115: Approve UnichainprotocolFeeupdate.The fee (
192111100000000) is now consistent with the updated rate model.deployments/warp_routes/EZETHSTAGE/renzo-stage-deploy.yaml (2)
5-22: Consolidate hook definitions withdomainRoutingHook.
Replaced individual hook entries and legacy fee/beneficiary fields underarbitrum.hook.hookswith a unifieddomainsmapping and settype: domainRoutingHook. This DRY refactor reduces repetition—please verify the listed addresses and owner are correct.
745-753: Prevent inbound traffic to Blast via asymmetric hook/ISM.
Underblast.hook, only aggregationHook entries remain, and theinterchainSecurityModuleis simplified to an emptydomainsblock withtype: domainRoutingIsm. This effectively blocks inbound messages while preserving outbound aggregation, matching the PR goal..changeset/lucky-badgers-care.md (1)
1-3: Frontmatter is well-formed
The YAML frontmatter correctly specifies a minor bump for@hyperlane-xyz/registry.deployments/warp_routes/EZETH/renzo-prod-deploy.yaml (9)
5-13: Consolidated domainRoutingHook for Arbitrum
The individual protocolFee hooks have been replaced with a singledomainRoutingHookthat spans all target domains. Validate that each domain key (base, berachain, bsc, etc.) points to the correct address and that no intended domain was omitted.
21-22: Confirm aggregation entry afterdomainRoutingHook
Ensure the secondary hook entry ("0x592cd754B947396255E50Cac10c519c7ee313919") is correct and that theaggregationHookremains properly ordered immediately after the routing hook.
255-263: Consolidated domainRoutingHook for Base
Mirrors the Arbitrum pattern—validate that all Base domain addresses and the owner match the intended deployment configuration.
270-272: Verify Base aggregationHook entry
Confirm that the standalone aggregation address ("0xFA6A5Ab6a77dDdf2936b538Fdc39DAe314Cc5500") is correct and that no legacy protocolFee hooks were inadvertently dropped.
505-513: Consolidated domainRoutingHook for Berachain
The multi–domain routing configuration is unified under a single hook. Verify that each Berachain domain mapping and the owner address remain accurate.
520-522: Verify Berachain hook type and secondary entry
Ensure thetype: domainRoutingHookand the subsequent aggregation address ("0x96003848cfc3C236d70661aF4722F404435a526d") reflect the correct roles and ordering.
752-753: Simplified Hook for Blast
Inbound hooks are removed to enforce outbound-only traffic, leaving just two aggregation addresses. Confirm these entries satisfy the “prevent inbound to blast” objective.
756-758: Asymmetric ISM configuration for Blast
Changed to a singledomainRoutingIsmwith emptydomains—this blocks inbound messaging. Validate that no fallback or multisig modules remain that could inadvertently allow inbound traffic.
770-778: Consolidated domainRoutingHook for BSC
Applied the same domainRouting consolidation for BSC. Please verify all target domain addresses and that the aggregationHook entry ("0x18431F422A9f32967054689673b7e1731Da233A7") is correct.Also applies to: 786-787
Description
The goal of this update to to prevent inbound to blast, but allow outbound from blast. This is accomplished through an asymmetric hook/ism setup:
This is generated by: hyperlane-xyz/hyperlane-monorepo#6444
Summary by CodeRabbit