Enable parallel shard upload in push_to_hub() using num_proc #7649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for parallel shard uploads in `Dataset.push_to_hub()` using the existing `num_proc` argument. - Changes are implemented inside `_push_parquet_shards_to_hub()` - Uses `multiprocessing.Pool` and `iflatmap_unordered` when `num_proc > 1` - Preserves original serial behavior if `num_proc` is None or ≤ 1 Fixes huggingface#7591
ArjunJagdale
changed the title
push_to_hub() for parallel shard upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7591
Add num_proc support to
push_to_hub()for parallel shard uploadThis PR adds support for parallel upload of dataset shards via the
num_procargument inDataset.push_to_hub().📌 While the
num_procparameter was already present in thepush_to_hub()signature and correctly passed to_push_parquet_shards_to_hub(), it was not being used to parallelize the upload.🔧 This PR updates the internal
_push_parquet_shards_to_hub()function to:multiprocessing.Poolandiflatmap_unordered()for concurrent shard upload whennum_proc > 1num_procisNoneor ≤ 1Let me know if any test coverage or further changes are needed!