Testing hz applications #1762
Testing hz applications #1762
Conversation
|
|
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
This looks great. A few comments in-line, and I've done a quick copy edit for style etc. Might be good to have a bit more detail on how you use the code samples, but difficult for me to assess as a non-developer.
Approving, but please don't merge without:
- Removing in-line notes
- Engineering approval
|
|
||
| For dependencies and tests setup, see: xref:testing-setup.adoc[Testing setup]. | ||
|
|
||
| == JUnit 4: `HazelcastTestSupport` |
There was a problem hiding this comment.
Throughout this file, are these code samples in the right places? E.g. you've got TestHazelcastFactory/InstanceFactory under JUnit 4, but you've said they're for JUnit 5?
|
|
||
| === `JetTestSupport` (JUnit4) | ||
|
|
||
| Extend `JetTestSupport` to test pipelines with in-process Hazelcast. This utility class provides lifecycle management and assertion methods specifically designed for streaming and batch dataflows. |
There was a problem hiding this comment.
Please use "embedded mode" terminology for consistency, unless that's not what this is referring to?
| @@ -0,0 +1,313 @@ | |||
| = Introduction to Hazelcast Performance Testing with Simulator | |||
|
|
|||
| *NOTE: THIS CONTENT IS WORK IN PROGRESS* | |||
There was a problem hiding this comment.
We can't publish with this note in place. Suggest either publishing this section as is, or removing it to a separate PR.
From my POV, there's some missing context under e.g. "inventory plan", but it doesn't look too far off completion.
|
|
||
| - Supports both *throughput* and *latency*-oriented testing modes. | ||
| - Orchestrates tests across multiple clients and members, with configurable topologies. | ||
| - Provides out-of-the-box support static infrastructure, (support for cloud deployments is not yet available). |
There was a problem hiding this comment.
How does this square with "running tests against cloud-deployed Hazelcast clusters"? Please remove any references to cloud support if it's not available.
| @@ -0,0 +1,394 @@ | |||
| = Summary of helper methods | |||
|
|
|||
| *NOTE: WE NEED TO AGREE WHAT METHODS WE WANT TO ENDORSE AND WHAT NOT. WHAT ARE THE METHODS THAT MAY BE USEFUL TO USERS?* | |||
There was a problem hiding this comment.
Again, don't publish (merge) without removing this note please.
| } | ||
| ---- | ||
|
|
||
| Shutting down a single instance can be used to mimic failure scenarios `ìnstance.shutdown()`. |
There was a problem hiding this comment.
Missing words, or new line with code sample?
|
Suggest adding "backport to all versions" label if there's nothing here tied to a future release |
This is a revisited section of the testing application docs here https://docs.hazelcast.com/hazelcast/5.5/test/testing-apps
After the workshop, where we introduced the full set of testing helpers, we thought about extending this section to provide full coverage of what's available.
there are two NOTES that require attention.
there's a side project which I am also hoping to merge in the hazelcast examples repo https://github.com/fcannizzohz/demo-hz-testing