Skip to content

Enable mapping of Text and Key & Updated Direct2D drawing #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

WindowsNT
Copy link

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these includes? which are moreover platform specific and hard coded!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What includes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in src/engine/devices/AbstractDevice.cpp
(unless I've misread the PR)

@dfober
Copy link
Member

dfober commented Jun 18, 2025

sorry, there are still windows specific includes and moreover with absolute paths
e.g. in src/engine/devices/AbstractDevice.cpp (but maybe in other files too)

#include "F:\\guidolib\\midisharelight\\src\\MidiShareLight.cpp"
#include "F:\\guidolib\\midisharelight\\src\\msEvents.cpp"
#include "F:\\guidolib\\midisharelight\\src\\msFields.cpp"
#include "F:\\guidolib\\midisharelight\\src\\msMemory.cpp"
#include "F:\\guidolib\\midisharelight\\src\\msSeq.cpp"
#include "F:\\guidolib\\midisharelight\\src\\lifo.cpp"
#include "F:\\guidolib\\midisharelight\\src\\midifile.cpp"

it'll break the compilation.

Next the PR includes 426 files ! most of them are project specific files, generated by cmake, by your dev environment, or as output of your compilation.
e.g.

.vs
out/build/...
.cmake
out32 at different levels of the hierarchy
out64 at different levels of the hierarchy

These files must not be included in your PR. They are specific to your local project.

Finally, all the src code is included in the PR, likely due to your file format (LF for Unix or CRLF for windows) or file encoding.
The expected format is Unix (CR) and encoding must be UTF8.

All that makes it impossible to check what has really changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants