Skip to content

Node 18 upgrade #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Google LLC
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,5 +13,4 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
digest: sha256:22e41dd7cd82683fa338b647abcc3a29ddb1b17e800b089adc0bec0a3175312c
# created: 2024-10-30T16:51:59.982020867Z
digest: sha256:0d39e59663287ae929c1d4ccf8ebf7cef9946826c9b86eda7e85d8d752dbb584
24 changes: 0 additions & 24 deletions .kokoro/continuous/node14/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node14/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/system-test.cfg

This file was deleted.

Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node14/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/system-test.cfg

This file was deleted.

Empty file.
6 changes: 3 additions & 3 deletions mock-server/datastore-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const GAX_PROTOS_DIR = resolve(
// @ts-ignore
// eslint-disable-next-line n/no-extraneous-require
dirname(require.resolve('google-gax')),
'../protos'
'../protos',
);

const grpc = require('@grpc/grpc-js');
Expand All @@ -42,7 +42,7 @@ const descriptor = grpc.loadPackageDefinition(packageDefinition);
*/
function grpcEndpoint(
call: {},
callback: (arg1: string | null, arg2: {}) => {}
callback: (arg1: string | null, arg2: {}) => {},
) {
// SET A BREAKPOINT HERE AND EXPLORE `call` TO SEE THE REQUEST.
callback(null, {message: 'Hello'});
Expand All @@ -62,6 +62,6 @@ export function startServer(cb: () => void) {
() => {
console.log('server started');
cb();
}
},
);
}
51 changes: 26 additions & 25 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,40 +46,41 @@
"async-mutex": "^0.5.0",
"concat-stream": "^2.0.0",
"extend": "^3.0.2",
"google-gax": "^4.0.5",
"google-gax": "^5.0.0-rc.3",
"is": "^3.3.0",
"protobufjs": "7.0.0",
"split-array-stream": "^2.0.0",
"stream-events": "^1.0.5"
},
"devDependencies": {
"@google-cloud/storage": "^7.0.1",
"@types/extend": "^3.0.1",
"@types/is": "0.0.25",
"@types/js-yaml": "^4.0.0",
"@types/mocha": "^9.0.0",
"@types/node": "^20.4.9",
"@types/proxyquire": "^1.3.28",
"@types/sinon": "^17.0.0",
"async": "^3.2.4",
"c8": "^9.0.0",
"gapic-tools": "^0.4.0",
"gts": "^5.0.0",
"js-yaml": "^4.0.0",
"jsdoc": "^4.0.0",
"@google-cloud/storage": "^7.15.2",
"@types/extend": "^3.0.4",
"@types/is": "^0.0.25",
"@types/js-yaml": "^4.0.9",
"@types/mocha": "^10.0.10",
"@types/node": "^22.13.10",
"@types/proxyquire": "^1.3.31",
"@types/sinon": "^17.0.4",
"async": "^3.2.6",
"c8": "^10.1.3",
"gapic-tools": "^1.0.1",
"gts": "^6.0.2",
"js-yaml": "^4.1.0",
"jsdoc": "^4.0.4",
"jsdoc-fresh": "^3.0.0",
"jsdoc-region-tag": "^3.0.0",
"linkinator": "^3.0.0",
"mocha": "^9.2.2",
"null-loader": "^4.0.0",
"p-queue": "^6.6.1",
"pack-n-play": "^2.0.0",
"linkinator": "^6.1.2",
"mocha": "^11.1.0",
"null-loader": "^4.0.1",
"p-queue": "^8.1.0",
"pack-n-play": "^3.0.0",
"proxyquire": "^2.1.3",
"sinon": "17.0.0",
"ts-loader": "^8.0.0",
"typescript": "^5.1.6",
"webpack-cli": "^5.0.0"
"sinon": "^19.0.2",
"ts-loader": "^9.5.2",
"typescript": "^5.8.2",
"webpack-cli": "^6.0.1"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18"
}
}
Loading
Loading