Skip to content

Refactor: Simplify Build Path and Update Generative AI Configuration #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patchen0518
Copy link

@patchen0518 patchen0518 commented Jun 30, 2025

This pull request introduces two key refactorings to improve code clarity and align with the latest library standards.

1. Simplified Build Path

The build path logic has been refactored to remove the repetitive use of parents.parents.parents.... This results in a more readable manner.

2. Updated generate_content Configuration

During a review of the generate_content function, I noticed the use of a config dictionary to set tools and temperature. While this approach functions, it appears to be based on a previous version of the API, as suggested by the deprecated generative-ai-python repository.

The official Google AI for Developers documentation use types.generatecontentconfig instead of using the old way.

Old Configuration:

config = {
    'tools': [{'Google Search': {}}],
    'temperature': 0,
}
# model.generate_content(..., config=config) # Likely older usage

I have updated the implementation to reflect this modern usage. If there is a specific reason for retaining the legacy config structure, I would be very interested to learn about it.

Copy link

google-cla bot commented Jun 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant