Fix/nestjs cron issues #16792
Open
Fix/nestjs cron issues #16792
+54
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2025 18:49
Add a command to delete the Sentry-related cache during the E2E test setup process. This ensures a clean testing environment and prevents potential issues caused by stale cache. This is why running tests locally after any change might be wrong. Not sure this is the best solution, or no. But, at least results are constant now
Introduced a new `testSyncCronError` method to handle sync cron job errors and updated the async method for clarity. Updated tests to cover both async and sync cron scenarios, ensuring proper error handling and reporting to Sentry.
Added error capturing for both synchronous and asynchronous exceptions in monitored methods. Incorporated `isThenable` checks to handle promises properly, ensuring robust error tracking with Sentry in both cases.
andreiborza
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
This looks good to me, thank you for contributing this!
cc @chargome
| @@ -66,6 +66,7 @@ async function run(): Promise<void> { | |||
| } | |||
|
|
|||
| await asyncExec('pnpm clean:test-applications', { env, cwd: __dirname }); | |||
| await asyncExec('pnpm cache delete "@sentry/*"', { env, cwd: __dirname }); | |||
There was a problem hiding this comment.
m: Is this necessary? Did you run into issues without it? I think we should not add this in this PR.
There was a problem hiding this comment.
To be honest - no, it is not necessary to be here in this PR. But yes, you are going to run into an issue without this. The issue is that if you are doing any changes to any package and want to run e2e tests locally with yarn workspace @sentry-internal/e2e-tests test:run app-name your very first test will be executed as expected. But any other changes are not going to be reflected by pnpm install because of the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nestjs sync task has the same issue as async tasks - they don't care about exceptions because nestjs
@Cron()decorator automatically wraps it totry-catchblock and logs an error. That's why we should capture exception in our@SentryCron()decorator.P.S. I didn't test, but, most probably, fixes also #16749
yarn lint) & (yarn test).