Skip to content

fix: have overlay show correct png on onResume #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mnbpdx
Copy link

@mnbpdx mnbpdx commented Jun 30, 2021

It looks like when onResume() was in a "disconnected" state, it was sending OverlayStatus.Connected to showOverlay() rather than OverlayStatus.Disconnected.

Could be wrong about this, I'm decently new to Android/coding in general so please check my work. That being said, my test device was showing the "connected" PNG when disconnected, and this seemed to solve it.

In fact, my device always showed the "connected" PNG, I think because the "disconnected" PNG that was set up in onCreate() was immediately being re-drawn by onResume().

Before changes (on initial start up, fresh install):
Screen Shot 2021-06-30 at 12 19 54 AM

After:
Screen Shot 2021-06-30 at 12 22 52 AM

@mnbpdx
Copy link
Author

mnbpdx commented Jun 30, 2021

While we're at it, that block of code is basically identical in both onCreate() and onResume(), I can pull it into its own method if ya like.

@jlucidar
Copy link
Member

Thanks @mnbpdx for your contribution !
It's already been fixed in #73 , with probably some other small issues :)
For your futur contributions, could you please make your PR to the "dev" branch instead of the master one ?
master is supposed to reflect what is shipped currently, dev is the latest non stable version with all the new features.

@jlucidar jlucidar closed this Jun 30, 2021
@mnbpdx
Copy link
Author

mnbpdx commented Jun 30, 2021

Ahh bummer, tried to search for it but must have missed it.

And I will make any future PR's to dev, thanks for calling that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants