Skip to content

Qemu Reorder #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

Qemu Reorder #842

merged 2 commits into from
Jul 16, 2025

Conversation

vanmaegima
Copy link
Member

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Reorder steps for a straight forward approach to avoid confusion.

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@vanmaegima vanmaegima requested a review from kprosise July 15, 2025 12:38
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, and much cleaner. Thanks!

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Reorder steps for a straight forward approach to avoid confusion.

Signed-off-by: Vanessa Maegima <vanessa.maegima@foundries.io>
@vanmaegima
Copy link
Member Author

@angolini done!
@kprosise it looks like the initial build for this has failed but it worked on my machine, can you take a look?

@kprosise
Copy link
Contributor

@angolini done! @kprosise it looks like the initial build for this has failed but it worked on my machine, can you take a look?

Yep, I believe that has been fixed in another PR, and the extension related to it is going to be removed in the near future anyway. I will take another look, but as I know it's not related to this PR, we can go ahead and merge.

@vanmaegima vanmaegima merged commit 3c99aec into foundriesio:main Jul 16, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants