-
Notifications
You must be signed in to change notification settings - Fork 28
WIP: enable Adobe analytics #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
* Import theme footer in order to apply metadata for analytics event. Signed-off-by: Milo Casagrande <milo@foundries.io>
* Some minor cleanups. * Add metadata for events triggering. Signed-off-by: Milo Casagrande <milo@foundries.io>
@kprosise it's still a little bit of a work in progress, but it should be 99% done. There is one thing that needs to be fixed though, but I have no idea how. We need to inject an env variable to pass the Adobe analytics URL. The env variable is needed here. I also fixed a couple of issues with the CSS, there were a couple of tags not closed correctly. |
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
@kprosise all the changes needed are in the PR and it has been tested on the beta instance. https://assets.adobedtm.com/7360c2888734/52f7999a6b6e/launch-2929f1dcda49.min.js When this is merged, when could it be deployed/re-built? They would like to have it done by this week if possible. Let me know if I can help in re-building it. |
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.