Skip to content

WIP: enable Adobe analytics #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 11, 2025
Merged

WIP: enable Adobe analytics #838

merged 18 commits into from
Jun 11, 2025

Conversation

MiloCasagrande
Copy link
Member

  • feat: add adobe analytics page load setup
  • feat: add cookie settings link in footer
  • fix: add missing closing curly-brace
  • fix: add indentation to styles
  • fix: remove css class not defined nor closed
  • feat: add CSS helper classes
  • feat: add analytics event triggering
  • feat: add template overrider for breadcrumbs
  • feat: add metadata for analytics event on search
  • feat: override footer template
  • fix: update layout template for analytics

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
	* Import theme footer in order to apply metadata
	  for analytics event.

Signed-off-by: Milo Casagrande <milo@foundries.io>
	* Some minor cleanups.
	* Add metadata for events triggering.

Signed-off-by: Milo Casagrande <milo@foundries.io>
@MiloCasagrande MiloCasagrande requested a review from kprosise May 28, 2025 16:08
@MiloCasagrande
Copy link
Member Author

MiloCasagrande commented May 28, 2025

@kprosise it's still a little bit of a work in progress, but it should be 99% done.
The implementation is being vetted via a beta website where I pushed the built docs.

There is one thing that needs to be fixed though, but I have no idea how. We need to inject an env variable to pass the Adobe analytics URL. The env variable is needed here.

I also fixed a couple of issues with the CSS, there were a couple of tags not closed correctly.

Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
Signed-off-by: Milo Casagrande <milo@foundries.io>
@MiloCasagrande MiloCasagrande changed the title WIP: enale Adobe analytics WIP: enable Adobe analytics Jun 4, 2025
Signed-off-by: Milo Casagrande <milo@foundries.io>
@MiloCasagrande
Copy link
Member Author

@kprosise all the changes needed are in the PR and it has been tested on the beta instance.
This is the production link for the adobe library:

https://assets.adobedtm.com/7360c2888734/52f7999a6b6e/launch-2929f1dcda49.min.js

When this is merged, when could it be deployed/re-built? They would like to have it done by this week if possible. Let me know if I can help in re-building it.

@kprosise kprosise merged commit 3674562 into main Jun 11, 2025
2 of 3 checks passed
@kprosise kprosise deleted the feat/adobe-analytics branch June 12, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants