Fix(storage): correct pipeline usage of RedisStorage to retrieve event_id and prevent type errors #177
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did this PR change
INCR
before using its result asevent_id
.INCR
command to increment event counter and retrieve the newevent_id
.SETEX
with the correctly retrievedevent_id
.Why was this change necessary
The original implementation misused the Redis pipeline API by directly assigning the result of
pipe.incr(...)
toevent_id
.However, in Redis-py, calling
pipe.incr(...)
does not immediately execute and instead queues the command, returning the pipeline object itself. This led to:event_id
being aPipeline
object, not an integer.-This also causing the following error when running django setting with "django_eventstream.storage.RedisStorage":
Notes
django_eventstream/storage.py
event_id
before using it in the second operation.