Skip to content

Add Initial Setup + GetBlobsV2 Metrics #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SunnysidedJ
Copy link

Hi,

I'd like to start spec-ing EL metrics with GetBlobsV2 as they seem to be useful in monitoring PeerDAS. I've copied the format from https://github.com/ethereum/beacon-metrics for consistency.

Discussion from Discord:
https://discord.com/channels/595666850260713488/1252403418941624532/1374373828691497064
Initial proposal (edited) from Sunnyside Labs:
https://testinprod.notion.site/Proposal-for-Unified-EL-metrics-for-PeerDAS-1d28fc57f54680f2a3cbfe408d7db4b8?source=copy_link

Issue: #1

@SunnysidedJ
Copy link
Author

@KatyaRyazantseva @mininny

@KatyaRyazantseva
Copy link

@SunnysidedJ could you please review thestructure proposal by @will-corcoran? This is the structure we are going to follow for metrics specs repos. Still in progress, feel free to comment.

@macfarla
Copy link

macfarla commented Jul 17, 2025

Q re how this will work with the changes here ethereum/execution-apis#674 for moving partial response behavior to getBlobsV3

  • will getBlobsV2 and getBlobsV3 use the same metrics
  • specifically for execution_engine_getblobs_available_total - once V2 is no longer returning partial responses, should this counter still be incremented with how many are available in the pool, even if null is returned? Or should it be all or nothing, in line with the response?

if context is helpful, PR for getBlobsV3 for besu hyperledger/besu#8967

@SunnysidedJ
Copy link
Author

Q re how this will work with the changes here ethereum/execution-apis#674 for moving partial response behavior to getBlobsV3

  • will getBlobsV2 and getBlobsV3 use the same metrics
  • specifically for execution_engine_getblobs_available_total - once V2 is no longer returning partial responses, should this counter still be incremented with how many are available in the pool, even if null is returned? Or should it be all or nothing, in line with the response?

if context is helpful, PR for getBlobsV3 for besu hyperledger/besu#8967

Pasting the same reply from the Discord channel here as well.

I think execution_engine_getblobs_available_total could still be a useful metric for GetBlobsV2 in few ways, ,e.g. it could be used to calculate how many blobs were available upon failure on average; (available_total - (requested_total * hit_ratio)) / miss_total.

It'd be nice if we have the same metrics for getBlobsV3 as well if we were to implement it for Fusaka. In addition to existing ones, another metric called something like execution_engine_getblobs_partial_hit_total would be very helpful in distinguishing between complete and partial hit returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants