erts: fix static function prototypes #9983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 complains about function prototypes without arguments: | port_test.c: In function 'packet_loop': | port_test.c:235:7: error: too many arguments to function 'ensure_buf_big_enough'; expected 0, have 1 | 235 | ensure_buf_big_enough(port_data->header_size); | | ^~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ | port_test.c:75:13: note: declared here | 75 | static void ensure_buf_big_enough();
CT Test Results 3 files 142 suites 49m 21s ⏱️ Results for commit f544d3c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
joaohf
commented
Jun 19, 2025
| @@ -212,7 +212,7 @@ int main(int argc, char *argv[]) | |||
| replace_stdout(port_data->output_file); | |||
|
|
|||
| if (port_data->fd_count) | |||
| reply(&fd_count, sizeof(fd_count)); | |||
| reply((char *) &fd_count, sizeof(fd_count)); | |||
There was a problem hiding this comment.
Might be not a good idea. Any thought ?
There was a problem hiding this comment.
This is what reply expects, so let's not change anything here.
|
Hi, This fix is also valid for master, 28, 27, 26, 25. |
jhogberg
approved these changes
Jun 30, 2025
| @@ -212,7 +212,7 @@ int main(int argc, char *argv[]) | |||
| replace_stdout(port_data->output_file); | |||
|
|
|||
| if (port_data->fd_count) | |||
| reply(&fd_count, sizeof(fd_count)); | |||
| reply((char *) &fd_count, sizeof(fd_count)); | |||
There was a problem hiding this comment.
This is what reply expects, so let's not change anything here.
jhogberg
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 15 complains about function prototypes without arguments:
| port_test.c: In function 'packet_loop':
| port_test.c:235:7: error: too many arguments to function 'ensure_buf_big_enough'; expected 0, have 1
| 235 | ensure_buf_big_enough(port_data->header_size);
| | ^~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
| port_test.c:75:13: note: declared here
| 75 | static void ensure_buf_big_enough();