Update macro_log typespec #10010
Open
Update macro_log typespec #10010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`log_allowed` which is called by `macro_log` actually accepts `location()` or `#{}`. I noticed this issue when running dialyzer on elixir codebase. There are justified usages of `macro_log` with an empty map argument and dialyzer emits:
```
lib/logger.ex:1005:41: The call 'Elixir.Logger':'__do_log__'
(_level@2 ::
'alert' | 'critical' | 'debug' | 'emergency' | 'error' |
'info' | 'notice' | 'warning',
_message_or_fun@1 :: any(),
#{},
map()) will never return since it differs in the 3rd argument from the success typing arguments:
('alert' | 'critical' | 'debug' | 'emergency' | 'error' |
'info' | 'notice' | 'warning',
any(),
#{'file' := string(),
'line' := non_neg_integer(),
'mfa' := {atom(), atom(), non_neg_integer()}},
map())
```
CT Test Results 2 files 70 suites 1h 6m 22s ⏱️ For more details on these failures, see this check. Results for commit 8063623. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_allowedwhich is called bymacro_logactually acceptslocation()or#{}. I noticed this issue when running dialyzer on elixir codebase. There are justified usages ofmacro_logwith an empty map argument and dialyzer emits: