-
Notifications
You must be signed in to change notification settings - Fork 113
Document proxy configuration for Java SDK #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
-Dhttp.proxyHost=proxy.example.com \ | ||
-Dhttp.proxyPort=8080 \ | ||
-Dhttps.proxyHost=proxy.example.com \ | ||
-Dhttps.proxyPort=8080 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did expect this to not work, because to my knowledge the exporters use OkHttp3
, which I thought would not respect these properties. However, according to this issue it should work. Did we test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jonas! It should work as of this PR.
It was double-checked by @AlexanderWert and @SylvainJuge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion for your consideration. Not an area of expertise for me, but otherwise LGTM.
-Dhttps.proxyPort=8080 \ | ||
``` | ||
|
||
## Best practices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about calling this "Testing" "Validation" or "Test your proxy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case yes, it would make sense. I was trying to stick to the Troubleshooting topic structure we came up with: Symptoms - Resolution - Best practices (optional) - Resources (optional)
I'll be adding a lot more OTel troubleshooting topics in the future, so I wanted to keep them organized in more or less the same way.
This PR adds a troubleshooting guide to help users resolve proxy issues when using EDOT Java SDK. The guide explains that the Java SDK requires explicit JVM proxy config.