Skip to content

Refined applies_to tooltips #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Refined applies_to tooltips #1495

wants to merge 13 commits into from
+102 −96

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jul 1, 2025 •
edited
Loading

Changes

  • Single tooltip instead of two (one for key and one for lifecycle)
  • Tooltips for every state

Preview

https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1495/syntax/applies#inline

@reakaleek reakaleek requested a review from a team as a code owner July 1, 2025 21:55
@reakaleek reakaleek self-assigned this Jul 1, 2025
@reakaleek reakaleek requested a review from bmorelli25 July 1, 2025 21:57
bmorelli25
bmorelli25 reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbirnstiehl / @florent-leborgne can you take a look at this PR? I think these are generally pretty good (but what do I know?). Your expertise would be quite helpful in tightening these up 🙏

bmorelli25
bmorelli25 reviewed Jul 1, 2025
View reviewed changes
reakaleek
reakaleek commented Jul 1, 2025
View reviewed changes
florent-leborgne
florent-leborgne reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!!! I left some comments, some may be worth discussing here, some maybe later.

@reakaleek
Copy link
Member Author

Feel free to commit the suggestions if appropriate and let me know when this is ready to merge.

mdbirnstiehl
mdbirnstiehl reviewed Jul 2, 2025
View reviewed changes
@florent-leborgne
Copy link
Contributor

Feel free to commit the suggestions if appropriate and let me know when this is ready to merge.

Will do that in the morning to give some time for NORAM folks to review as well

@reakaleek reakaleek mentioned this pull request Jul 3, 2025
Closed
florent-leborgne
florent-leborgne approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reakaleek sorry for the delay and thanks a lot for putting those in. I applied the changes. Will let you deal with the conflict in case this relates to the "adding GA to planned if preview or beta exists" other PR.

LGTM

@reakaleek
Merge branch 'main' into feature/applies-to-tooltips
52d337c 
# Conflicts:
#	src/Elastic.Markdown/Myst/Components/ApplicableToComponent.cshtml
@reakaleek reakaleek enabled auto-merge (squash) July 4, 2025 09:01
@reakaleek reakaleek requested review from cotti and bmorelli25 July 4, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis left review comments

@mdbirnstiehl mdbirnstiehl mdbirnstiehl left review comments

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@cotti cotti Awaiting requested review from cotti

@bmorelli25 bmorelli25 Awaiting requested review from bmorelli25

At least 1 approving review is required to merge this pull request.

Assignees

@reakaleek reakaleek

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reakaleek @florent-leborgne @bmorelli25 @colleenmcginnis @mdbirnstiehl