Skip to content

test: add epic_ip6_extended to check-overlap-tgeo #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 5, 2025

This is a test for #903 (comment)

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Jul 5, 2025
@veprbl
Copy link
Member Author

veprbl commented Jul 5, 2025

@simonge I don't see an issue in the ip6_extended configuration. By any chance, did you have a better test that we could implement? Or, maybe, we need to do geant4 scan from e.g. different origin?

@simonge
Copy link
Contributor

simonge commented Jul 5, 2025

@simonge I don't see an issue in the ip6_extended configuration. By any chance, did you have a better test that we could implement? Or, maybe, we need to do geant4 scan from e.g. different origin?

Just checked and my local overlap check was running with a limit of 0.01 mm rather than 0.1 mm. I wouldn't recommend doing this for the full geometry at the moment. Although the overlaps between the main and my branch which should fix the stuck tracks doesn't seem to report any different detector elements, this might just be that these torus slithers are even smaller than the overlap checks at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants