Skip to content

Modified ETOF geometry implementation for ACTS track reconstruction #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
229e32c
Chagned ETOF layering.
ssedd1123 Jun 7, 2025
390e657
Modified the structure of EndcapTOF construction and model after Endc…
ssedd1123 Jun 8, 2025
4b99cc8
Fixed formating.
ssedd1123 Jun 8, 2025
3bdcce7
Fix ACTS layering issue by renameing to layer volume.
ssedd1123 Jun 13, 2025
e53556f
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 13, 2025
9f08fb7
Solved layer overlapping bug.
ssedd1123 Jun 15, 2025
fb22ef4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 15, 2025
408656c
Removed TOFEndcap_nLayers from tof_endcap.xml
ssedd1123 Jun 18, 2025
f19ff9a
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ShujieL Jun 18, 2025
93dd8c4
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 21, 2025
efa37b8
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 22, 2025
178776c
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ShujieL Jun 23, 2025
6efa481
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 26, 2025
a6c4824
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 26, 2025
a5e9b47
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 29, 2025
8b8b134
Removed fudge distances, hard-coded lenghts and redundent parameters.
ssedd1123 Jun 29, 2025
d50a7cf
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
ssedd1123 Jun 29, 2025
4c03484
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 29, 2025
141a06f
move backward TOF to -1 um.
ssedd1123 Jun 29, 2025
b9834b2
Trigger Build
ssedd1123 Jun 30, 2025
f72aff6
Removed commented code
ssedd1123 Jul 3, 2025
b0216d5
for loop on line 71 is simplified.
ssedd1123 Jul 3, 2025
807877b
Merge branch 'main' into pr/fix_ETOF_layering_for_ACTS
bschmookler Jul 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 48 additions & 45 deletions compact/tracking/tof_endcap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@

<lccdd>
<define>
<documentation>
## Forward TOF double-disks
</documentation>

<comment>
--------------------------
Forward TOF Parameters
--------------------------
</comment>
<comment> Forward TOF position </comment>
<constant name="ForwardTOF_nlayers" value="1"/>
<constant name="ForwardTOFMod_offset" value="1.2*cm"/>

<comment> LGAD parameters for the endcap TOFs </comment>
Expand Down Expand Up @@ -91,16 +94,9 @@
<constant name="SH_PB_offset" value="0.0*mm" />
<constant name="SH_PB_length" value="TOFEndcap_baseplate_length" />

</define>

<documentation>
## Forward TOF double-disks
</documentation>

<comment>
Actual detector implementation.
</comment>
<define>

<constant name="TOFEndcapMod_thickness" value="TOFEndcapSensor_thickness + TOFEndcapService_thickness" />
<constant name="TOFEndcapMod_angle" value="360.0*degree / TOFEndcapMod_count * (1 + TOFEndcapMod_overlap)" />
Expand Down Expand Up @@ -213,7 +209,7 @@
reflect="false">
<type_flags type="DetType_TRACKER + DetType_ENDCAP"/>
<position x="0*cm" y="0*cm" z="ForwardTOF_zmin" />
<moduleFrontRight name="EndcapTOF_Module1" vis="TOFEndcapModuleVis">
<module name="FrontRight" vis="TOFEndcapModuleVis">
<module_component name="hybridkaptontop" material="Kapton" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_Hybrid_thickness" vis="TOFHybridVis" >
<position x="EndcapTOF_Service_position" y="0" z="0" />
</module_component>
Expand Down Expand Up @@ -241,9 +237,9 @@
<module_component name="carbonsupport" material="CarbonFiber" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_CFSupp_thickness" vis="AnlGray" >
<position x="EndcapTOF_Support_position" y="0" z="0" />
</module_component>
</moduleFrontRight>
</module>

<moduleFrontLeft name="EndcapTOF_Module1" vis="TOFEndcapModuleVis">
<module name="FrontLeft" vis="TOFEndcapModuleVis">
<module_component name="hybridkaptontop" material="Kapton" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_Hybrid_thickness" vis="TOFHybridVis" >
<position x="EndcapTOF_Service_position" y="0" z="0" />
</module_component>
Expand Down Expand Up @@ -272,9 +268,9 @@
<module_component name="carbonsupport" material="CarbonFiber" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_CFSupp_thickness" vis="AnlGray" >
<position x="EndcapTOF_Support_position" y="0" z="0" />
</module_component>
</moduleFrontLeft>
</module>

<moduleBackRight name="EndcapTOF_Module1" vis="TOFEndcapModuleVis">
<module name="BackRight" vis="TOFEndcapModuleVis">
<module_component name="carbonsupport" material="CarbonFiber" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_CFSupp_thickness" vis="AnlGray" >
<position x="EndcapTOF_Support_position" y="0" z="0" />
</module_component>
Expand Down Expand Up @@ -302,9 +298,9 @@
<module_component name="hybridkaptontop" material="Kapton" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_Hybrid_thickness" vis="TOFHybridVis" >
<position x="EndcapTOF_Service_position" y="0" z="0" />
</module_component>
</moduleBackRight>
</module>

<moduleBackLeft name="EndcapTOF_Module1" vis="TOFEndcapModuleVis">
<module name="BackLeft" vis="TOFEndcapModuleVis">
<module_component name="carbonsupport" material="CarbonFiber" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_CFSupp_thickness" vis="AnlGray" >
<position x="EndcapTOF_Support_position" y="0" z="0" />
</module_component>
Expand Down Expand Up @@ -332,31 +328,22 @@
<module_component name="hybridkaptontop" material="Kapton" sensitive="false" width="EndcapTOF_Module_width" length="EndcapTOF_Module_length" thickness="EndcapTOF_Hybrid_thickness" vis="TOFHybridVis" >
<position x="EndcapTOF_Service_position" y="0" z="0" />
</module_component>
</moduleBackLeft>
</module>

<layer id="1" front="true" name="Front">

<envelope vis="TOF_envelope"
rmin="ForwardTOFLayer_rmin"
rmax="ForwardTOFLayer_rmax"
zstart="ForwardTOF_zmin - EndcapTOF_CFSupp_thickness"
xoffset="-EndcapTOF_Board_spacing/2"
/>


<layer module="EndcapTOF_Module1" id="1">
<envelope vis="TOF_envelope"
rmin="ForwardTOFLayer_rmin"
rmax="ForwardTOFLayer_rmax"
length="3*cm"
zstart="ForwardTOF_zmin"
xoffset="EndcapTOF_Module_length_design/2"
/>
<layer_material surface="inner" binning="binPhi,binR" bins0="30" bins1="30"/>
<layer_material surface="outer" binning="binPhi,binR" bins0="30" bins1="30"/>
<y_layout dr="0.0*mm" z0="EndcapTOF_zOffset" nz="EndcapTOF_Module_nz"/>
<z_layout z0="ForwardTOF_zmin"/>
</layer>
<support module="EndcapTOF_SupportDummy" id="1" vis="InvisibleWithDaughters">
<envelope vis="AnlGray"
rmin="ForwardTOFLayer_rmin"
rmax="ForwardTOFLayer_rmax"
length="12*mm"
zstart="ForwardTOF_zmin"
xoffset="EndcapTOF_Module_length_design/2" />

</support>
<sensor_layout_front_left>

<layout module="FrontLeft" left="true">
<row deadspace="15*mm + EndcapTOF_yOffset"/>
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
Expand Down Expand Up @@ -426,9 +413,8 @@
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
</row>
</sensor_layout_front_left>

<sensor_layout_front_right>
</layout>
<layout left="false" module="FrontRight">
<row deadspace="25.5*mm + EndcapTOF_yOffset"/>
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
Expand Down Expand Up @@ -496,9 +482,22 @@
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
</row>
</sensor_layout_front_right>
</layout>
</layer>

<layer id="2" front="false" name="Back">
<envelope vis="TOF_envelope"
rmin="ForwardTOFLayer_rmin"
rmax="ForwardTOFLayer_rmax"
zstart="ForwardTOF_zmin + EndcapTOF_CFSupp_thickness"
xoffset="-EndcapTOF_Board_spacing/2"
/>


<layer_material surface="inner" binning="binPhi,binR" bins0="30" bins1="30"/>
<layer_material surface="outer" binning="binPhi,binR" bins0="30" bins1="30"/>

<sensor_layout_back_left>
<layout left="true" module="BackLeft">
<row deadspace="25.5*mm + EndcapTOF_yOffset"/>
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
Expand Down Expand Up @@ -566,9 +565,9 @@
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
</row>
</sensor_layout_back_left>
</layout>

<sensor_layout_back_right>
<layout left="false" module="BackRight">
<row deadspace="15*mm + EndcapTOF_yOffset"/>
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
Expand Down Expand Up @@ -638,7 +637,11 @@
<row x_offset="EndcapTOF_Board_spacing/2" nsensors="3">
<board nsensors="3"/>
</row>
</sensor_layout_back_right>
</layout>
</layer>




<modsize
width="EndcapTOF_Module_width"
Expand Down
Loading
Loading