Skip to content

Femcal update #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
463e91c
initial version of fEcal update with current design
Mar 5, 2025
0c3a786
include beam pipe protector instead of insert.h
Mar 6, 2025
0259f97
z location update, new yml files, and hit update
Mar 10, 2025
3ae5445
Adding a version with actual 760 ScFi
Mar 12, 2025
ca908f4
adding fake CartesianGridXY for ScFi hits for speed while looking for
akioogawa Apr 1, 2025
2ab0ad8
hit and detector name back to original. Small bug fix in map
akioogawa May 1, 2025
f133db2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 2, 2025
f908817
Merge branch 'main' into fEcal_update
akioogawa May 2, 2025
d2f94ee
spdx
akioogawa May 2, 2025
8326c34
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 2, 2025
15db2d2
changing craterlake.yml for auto overlap check
akioogawa May 2, 2025
be6af38
Delete configurations/craterlake_newfEcal.yml
akioogawa May 2, 2025
76a7834
just renaming
akioogawa May 2, 2025
8026edc
name change
akioogawa May 2, 2025
cea4eb1
rename preparing for merging
akioogawa May 2, 2025
6d07ce2
Merging 2 geo.cpp
akioogawa May 3, 2025
71a470a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 3, 2025
18dcd8f
switching to new forward ecal geometry in all confiugration
akioogawa May 5, 2025
0b7b36f
Fix typo which caused a crash
akioogawa May 5, 2025
5d53535
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 5, 2025
89b3f8e
Merge branch 'main' into fEcal_update
akioogawa May 5, 2025
44985a4
fix overlap with mother volume for bpp
akioogawa May 6, 2025
2ee4f7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 6, 2025
6d18af3
fix material for homogeneous and name change for some volumes
akioogawa May 7, 2025
e2210eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 7, 2025
c70ed92
Merge branch 'main' into fEcal_update
akioogawa May 9, 2025
4469a12
Merge branch 'main' into fEcal_update
veprbl Jun 3, 2025
cb2d525
Merge branch 'main' into fEcal_update
veprbl Jun 5, 2025
4001c76
Merge branch 'main' into fEcal_update
akioogawa Jun 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compact/definitions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ Examples:
Service gaps in FW direction (before endcapP ECAL) and BW direction (before endcapN HCAL)
</documentation>
<constant name="ForwardInnerEndcapRegionExtraSpace_length" value="4.6*cm"/>
<constant name="ForwardServiceGap_length" value="9.6*cm"/>
<constant name="ForwardServiceGap_length" value="15.4*cm"/>
<constant name="ForwardServiceGap_zmin" value="ForwardPIDRegion_zmin + ForwardInnerEndcapRegion_length + ForwardInnerEndcapRegionExtraSpace_length"/>
<constant name="ForwardServiceGap_zmax" value="ForwardServiceGap_zmin + ForwardServiceGap_length"/>

Expand All @@ -564,11 +564,11 @@ Service gaps in FW direction (before endcapP ECAL) and BW direction (before endc
</documentation>
<constant name="EcalBarrelSectorsN" value="48"/>
<constant name="EcalEndcapP_zmin" value="ForwardServiceGap_zmax" />
<constant name="EcalEndcapP_length" value="30*cm" />
<constant name="EcalEndcapP_length" value="27*cm" />
<constant name="EcalEndcapP_zmax" value="EcalEndcapP_zmin + EcalEndcapP_length"/>
<constant name="EcalEndcapP_rmin" value="200.0*mm" />
<comment> extra 50cm rmax that "protrudes" into the HCAL</comment>
<constant name="EcalEndcapP_rmax" value="195.0*cm"/>
<constant name="EcalEndcapP_rmax" value="206.1464*cm"/>
<constant name="EcalEndcapP_numLayers" value="1"/>

<constant name="EcalEndcapPInsert_zmin" value="EcalEndcapP_zmin"/>
Expand Down
86 changes: 86 additions & 0 deletions compact/ecal/forwardEcal.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@

<!-- SPDX-License-Identifier: LGPL-3.0-or-later -->
<!-- Copyright (C) 2025 Akio Ogawa, Whitney Armstrong, Chao Peng, Sylvester Joosten, Zhongling Ji, Ryan Milton -->

<lccdd>

<info name="forwardEcal.xml"
title="forward ECal 2025 design"
author="@akioogawa"
url="https://github.com/akioogawa"
status="development"
version="1.0">
<comment/></info>

<define>
<documentation>
- Forward Ecal Homogeneous(1) or ScFi(2) Model
</documentation>
<constant name="ForwardEcal_Homogeneous_Scfi" value="1"/>

<documentation>
- Forward Ecal Slice Thickness
</documentation>
<constant name="ForwardEcalCoverThickness" value="0.343*mm"/>
<constant name="ForwardEcalAirThickness" value="61.457*mm"/>
<constant name="ForwardEcalPCBThickness" value="4.5*mm"/>
<constant name="ForwardEcalLightGuideThickness" value="21.0*mm"/>
<constant name="ForwardEcalScintillatorThickness" value="170.0*mm"/>
<constant name="ForwardEcalMountingPlateThickness" value="12.7*mm"/>

<documentation>
- Forward Ecal computed total Thickness
</documentation>
<constant name="ForwardEcalThickness"
value = "ForwardEcalCoverThickness +
ForwardEcalAirThickness +
ForwardEcalPCBThickness +
ForwardEcalLightGuideThickness +
ForwardEcalScintillatorThickness +
ForwardEcalMountingPlateThickness"
/>
</define>

<limits>
</limits>

<regions>
</regions>

<display>
</display>

<detectors>

<documentation>
### Forward (Positive Z) Endcap ScFi Electromagnetic Calorimeter
Implementation of 2025 design
Insert shape is cut out from middle of detector
</documentation>
<detector id="EcalEndcapP_ID"
name="EcalEndcapP"
type="epic_ForwardEcal"
readout="EcalEndcapPHits">
<position x="0" y="0" z="EcalEndcapP_zmin"/>
<dimensions rmin="EcalEndcapP_rmin" rmax="EcalEndcapP_rmax" z="ForwardEcalThickness"/>
<slice name="Cover" material="Aluminum" thickness="ForwardEcalCoverThickness" vis="AnlGray"/>
<slice name="Air" material="Air" thickness="ForwardEcalAirThickness" vis="AnlLight_Gray"/>
<slice name="PCB" material="Fr4" thickness="ForwardEcalPCBThickness" vis="AnlGreen"/>
<slice name="LG" material="Plexiglass" thickness="ForwardEcalLightGuideThickness" vis="AnlBlue"/>
<slice name="WScFi" material="AvgTungstenScFi" thickness="ForwardEcalScintillatorThickness" vis="AnlOrange" sensitive="true"/>
<slice name="MountingPlate" material="StainlessSteel" thickness="ForwardEcalMountingPlateThickness" vis="AnlGray"/>
</detector>
</detectors>

<!-- Definition of the readout segmentation/definition -->
<readouts>
<readout name="EcalEndcapPHits">
<segmentation type="CartesianGridXY" grid_size_x="25*mm" grid_size_y="25*mm" offset_x="-37.5*mm" offset_y="-37.5*mm"/>
<id>system:8,northsouth:1,blockrow:6,blockcol:5,x:2,y:2</id>
</readout>
</readouts>

<plugins>
</plugins>

</lccdd>
86 changes: 86 additions & 0 deletions compact/ecal/forwardEcalScFi.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
<!-- SPDX-License-Identifier: LGPL-3.0-or-later -->
<!-- Copyright (C) 2025 Akio Ogawa, Whitney Armstrong, Chao Peng, Sylvester Joosten, Zhongling Ji, Ryan Milton -->

<lccdd>

<info name="forwardEcalScFi.xml"
title="forward ECal 2025 design"
author="@akioogawa"
url="https://github.com/akioogawa"
status="development"
version="1.0">
<comment/></info>

<define>
<documentation>
- Forward Ecal Homogeneous(1) or ScFi(2) Model
</documentation>
<constant name="ForwardEcal_Homogeneous_Scfi" value="2"/>

<documentation>
- Forward Ecal Slice Thickness
</documentation>
<constant name="ForwardEcalCoverThickness" value="0.343*mm"/>
<constant name="ForwardEcalAirThickness" value="61.457*mm"/>
<constant name="ForwardEcalPCBThickness" value="4.5*mm"/>
<constant name="ForwardEcalLightGuideThickness" value="21.0*mm"/>
<constant name="ForwardEcalScintillatorThickness" value="170.0*mm"/>
<constant name="ForwardEcalMountingPlateThickness" value="12.7*mm"/>

<documentation>
- Forward Ecal computed total Thickness
</documentation>
<constant name="ForwardEcalThickness"
value = "ForwardEcalCoverThickness +
ForwardEcalAirThickness +
ForwardEcalPCBThickness +
ForwardEcalLightGuideThickness +
ForwardEcalScintillatorThickness +
ForwardEcalMountingPlateThickness"
/>
</define>

<limits>
</limits>

<regions>
</regions>

<display>
</display>

<detectors>

<documentation>
### Forward (Positive Z) Endcap ScFi Electromagnetic Calorimeter
Implementation of 2025 design
Insert shape is cut out from middle of detector
</documentation>
<detector id="EcalEndcapP_ID"
name="EcalEndcapP"
type="epic_ForwardEcal"
readout="EcalEndcapPHits">
<position x="0" y="0" z="EcalEndcapP_zmin"/>
<dimensions rmin="EcalEndcapP_rmin" rmax="EcalEndcapP_rmax" z="ForwardEcalThickness"/>
<slice name="Cover" material="Aluminum" thickness="ForwardEcalCoverThickness" vis="AnlGray"/>
<slice name="Air" material="Air" thickness="ForwardEcalAirThickness" vis="AnlLight_Gray"/>
<slice name="PCB" material="Fr4" thickness="ForwardEcalPCBThickness" vis="AnlGreen"/>
<slice name="LG" material="Plexiglass" thickness="ForwardEcalLightGuideThickness" vis="AnlBlue"/>
<slice name="WScFi" material="AvgTungstenScFi" thickness="ForwardEcalScintillatorThickness" vis="AnlOrange" sensitive="true"/>
<slice name="MountingPlate" material="StainlessSteel" thickness="ForwardEcalMountingPlateThickness" vis="AnlGray"/>
</detector>
</detectors>

<!-- Definition of the readout segmentation/definition -->
<readouts>
<readout name="EcalEndcapPHits">
<!-- <segmentation type="NoSegmentation"/> --> <!-- Adding this slow down startup to >30min -->
<segmentation type="CartesianGridXY" grid_size_x="10*cm" grid_size_y="10*cm" offset_x="-0.0*cm" offset_y="-0.0*cm"/>
<id>system:8,northsouth:1,blockrow:6,blockcol:5,towerx:2,towery:2,fiberx:5,fibery:5,x:1,y:1</id>
</readout>
</readouts>

<plugins>
</plugins>

</lccdd>
2 changes: 1 addition & 1 deletion compact/materials.xml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
<fraction n="0.006" ref="Fe"/>
</material>
<material name="AvgTungstenScFi">
<D value="10.15" unit="g / cm3"/>
<D value="9.5" unit="g / cm3"/> <!-- More realistic number from Oleg -->
<fraction n="0.948" ref="W"/>
<fraction n="0.052*19./40" ref="C"/>
<fraction n="0.052*21./40" ref="H"/>
Expand Down
3 changes: 3 additions & 0 deletions configurations/becal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
ecal:
bic_default:
3 changes: 1 addition & 2 deletions configurations/calorimeters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ features:
beampipe:
solenoid:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
hcal:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x100.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x100_Au197.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x115_Cu63.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x115_Ru96.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x130.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x130_H2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x166_He3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x250.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_10x275.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_18x110_Au.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_18x110_He3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_18x275.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_5x100.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_5x41.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_bic_6layers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_6layers:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_bic_layer1_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_layer1_only:
backward_PbWO4:
solenoid:
Expand Down
3 changes: 1 addition & 2 deletions configurations/craterlake_no_bhcal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ features:
pfrich:
drich:
ecal:
forward_homogeneous:
forward_insert_homogeneous:
forwardEcal:
bic_default:
backward_PbWO4:
solenoid:
Expand Down
Loading
Loading