Add edm4eic::Jet
#118
Open
Add edm4eic::Jet
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Jul 9, 2025
| Description: "A reconstructed jet, inspired by the FastJet PseudoJet" | ||
| Author: "D. Anderson" | ||
| Members: | ||
| - float area // jet area [sr] |
There was a problem hiding this comment.
Suggested change
| - float area // jet area [sr] | |
| - float area // jet area |
| - edm4hep::Vector3f momentum // jet 3-momentum [GeV] | ||
| OneToManyRelations: | ||
| - edm4eic::Jet jets // jets that have been combined to form this jet | ||
| - edm4eic::ReconstructedParticle constituents // constituents of the jets |
There was a problem hiding this comment.
We don't want to imply that the stuff in constituents is necessarily a simple union of what jets have
Suggested change
| - edm4eic::ReconstructedParticle constituents // constituents of the jets | |
| - edm4eic::ReconstructedParticle constituents // constituents of this jet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Following the discussion in #88 , this PR introduces
edm4eic::Jet. This type, inspired by thefastjet::PseudoJet, aims to represent jets in our data model in a more adequate way thanedm4eic::ReconstructedParticle.Note these 3 design choices:
edm4eic::ReconstructedParticleare allowed as constituents, which places jet reconstruction in the final stages of reconstruction,jetsallows for either the indication of/connection to sub-jets, seed jets (which may be deployed in background-subtraction algorithms), or background jets (e.g. off-axis cones).What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.