Wip/verify unime core compat

[berkes]

This pull request introduces some minor changes to comply to the spec and interop with unime-core running at poc9

Schema and Validation Updates:

• src/lib/schemas/OpenidCredentialIssuerMetadataSchema.ts: Made the locale field optional in the display object within the schema.
• src/lib/services/credential-offer.service.ts: Standardized quotation marks to double quotes and improved the handling of credential_offer_uri by decoding the URI before making a fetch request.

[Copilot]

Pull Request Overview

This PR adjusts schema validation and credential-offer handling to align with the spec and improve unime-core interop.

• Made locale optional in issuer metadata schema
• Standardized quote style and added URI decoding in credentialOfferFromUrl
• Added handling for AcademicEnrollmentCredential display name and issuer fallback in UI components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/lib/schemas/OpenidCredentialIssuerMetadataSchema.ts	Marked locale as optional in the display object
src/lib/services/credential-offer.service.ts	Switched to double quotes and decode credential_offer_uri before fetching
src/context/ContainerContext.tsx	Added branch for AcademicEnrollmentCredential display name
src/components/Credentials/CredentialInfo.js	Introduced issuerName state and fallback in the issuer row

Comments suppressed due to low confidence (2)

src/components/Credentials/CredentialInfo.js:217

• The issuer row falls back to issuerName (from beautifiedForm.issuer.name) but otherwise uses credentialSubject.issuer. Verify whether the fallback should replace credentialSubject.issuer entirely or if the two fields are intended to differ.

								{!credentialSubjectRows.some(row => row.name === 'issuer') && renderRow('issuer', 'Issuer', parsedCredential?.vc?.credentialSubject?.issuer || issuerName, screenType)}

src/lib/services/credential-offer.service.ts:7

• Consider adding unit tests for credentialOfferFromUrl to cover scenarios where credential_offer is present, where credential_offer_uri is decoded successfully, and where fetch fails or returns non-OK responses.

export const credentialOfferFromUrl = async (url: string) => {

[Copilot]

Using || '' for credential_offer_uri means offerURI can be empty and lead to fetch(''). Add a guard to return an error or throw if the parameter is missing before attempting to fetch.

Suggested change

	parsedUrl.searchParams.get(PARAM_CREDENTIAL_OFFER_URI) || "";
	parsedUrl.searchParams.get(PARAM_CREDENTIAL_OFFER_URI);
	if (!offerURI) {
	throw new Error(`Missing or empty parameter: ${PARAM_CREDENTIAL_OFFER_URI}`);
	}

[Copilot]

After fetching the credential offer, check response.ok and handle non-2xx statuses (e.g., throw or return a structured error) before calling response.json() to improve error clarity.

Suggested change

	const response = await fetch(decodedOfferURI, {});
	const response = await fetch(decodedOfferURI, {});
	if (!response.ok) {
	throw new Error(`Failed to fetch credential offer: ${response.status} ${response.statusText}`);
	}

[Copilot]

[nitpick] This growing chain of if statements for credential types may become hard to extend. Consider refactoring into a mapping or switch statement to improve readability and make future additions simpler.

Suggested change

	if (isOpenBadgeCredential) return beautifiedForm.credentialSubject.achievement.name;
	if (t.includes('SupportCredential') || t.includes('ExamEnrollmentCredential')) return beautifiedForm.credentialSubject.title;
	if (t.includes('AcademicEnrollmentCredential')) return beautifiedForm.credentialSubject.name;
	if (storedCredentialConfigurationId === 'EduID') return 'eduID'
	const credentialTypeMapping: Record<string, () => string> = {
	'OpenBadgeCredential': () => beautifiedForm.credentialSubject.achievement.name,
	'SupportCredential': () => beautifiedForm.credentialSubject.title,
	'ExamEnrollmentCredential': () => beautifiedForm.credentialSubject.title,
	'AcademicEnrollmentCredential': () => beautifiedForm.credentialSubject.name,
	};
	if (storedCredentialConfigurationId === 'EduID') return 'eduID';
	for (const [key, getName] of Object.entries(credentialTypeMapping)) {
	if (t.includes(key)) {
	return getName();
	}
	}

[jessevanmuijden]

This is a temporary solution pending a discussion pertaining to credential card title display logic. There is no need to optimize it right now.

[jessevanmuijden]

I would just keep single quotes unless double quotes is the preferred formatting. In the latter case, please also update the formatting in other touched files.