Update the Hawkbit chart to be compatible with external secrets #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give existingSecrets examples Add existingSecrets for the hawkbit passwords Integrate mysql and rabbitmq secrets from the subcharts Move internal secrets out of SPRING_APPLICATION_JSON, and into individual environment variables
rather than just key value pairs, but maintain backward compatiblity
joshua-clayton
force-pushed
the
hawkbit-chart
branch
from
e5c6784 to
ec89f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the Hawkbit chart was not compatible with 'existingSecret', and
also that I couldn't even inject a secret via extraEnv,
I ended up replacing SPRING_APPLICATION_JSON with several individual environment variables,
in order to have more fine grained control.
Where possible I've kept it backwards compatible, though I'm not sure if that is the best way forward,
I either need to do more work to be perfectly backward compatible, or provide a migration guide, and
explain how the values.yaml needs to change to move to this version.
I'm just. starting to test this updated chart, so there may be bugs. I also hope to update to the latest version of hawkbit,
but my first attempt to do that didn't go well.
It is not my desire to permanently fork the chart,
I'm pushing this as a draft PR to see if I get any feedback. I'm happy to make changes to better suit the project.