Fix deb package version field

[Mycron]

issue: #3143
The suggestion to resolve #3143

[ocaisa]

I'm no expert here but shouldn't we somehow concat this with the change below so the function returns either 4.x.x~eb or 4.x.x~ebdev...or is it ok to have 2 ~?

[Mycron]

Good information to clarify and analyze it may be here: https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
As I understand, having two tildas is allowed. And in the case of having 4.x.x~eb and 4.x.x~dev~eb, the first one seems to be the latest

[Mycron]

To be honest, I didn't check such form for the case of rpm packages

[ocaisa]

For me then this seems ok, but maybe @boegel should give the final ok

[ocaisa]

@Mycron You will need to update the tests in test/framework/package.py to reflect the updated naming

[boegelbot]

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-framework/builds/637435167

Only showing partial log for 1st failed test suite run 3788.1;
full log at https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435168

...
.Skipping test_fetch_easyconfigs_from_pr, no GitHub token available?
.Skipping test_fetch_latest_commit_sha, no GitHub token available?
.Skipping test_fetch_pr_data, no GitHub token available?
.Skipping test_find_easybuild_easyconfig, no GitHub token available?
..Skipping test_install_github_token, no GitHub token available?
.Skipping test_list_prs, no GitHub token available?
..Skipping test_read, no GitHub token available?
.Skipping test_read_api, no GitHub token available?
.Skipping test_reasons_for_closing, no GitHub token available?
.Skipping test_restclient, no GitHub token available?
.Skipping test_validate_github_token, no GitHub token available?
.Skipping test_walk, no GitHub token available?
.........................................................FF.......................................................................................................................F..E..........................................
WARNING: Robot search path is empty!

.
WARNING: Robot search path is empty!

.
WARNING: Robot search path is empty!

.
======================================================================
ERROR: test_package (test.framework.package.PackageTest)
Test package function.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/package.py", line 228, in test_package
    pkgtxt = read_file(pkgfile)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/tools/filetools.py", line 191, in read_file
    raise EasyBuildError("Failed to read %s: %s", path, err)
EasyBuildError: "Failed to read /tmp/eb-QaM9DG/eb-nO03Hh/eb-o1_tgh/eb-OjF3AO/eb-5G10RS/eb-pkgs-9PZqO1/toy-0.0-gompi-2018a-test-eb-4.1.1.dev0.1.rpm: [Errno 2] No such file or directory: '/tmp/eb-QaM9DG/eb-nO03Hh/eb-o1_tgh/eb-OjF3AO/eb-5G10RS/eb-pkgs-9PZqO1/toy-0.0-gompi-2018a-test-eb-4.1.1.dev0.1.rpm'"

======================================================================
FAIL: test_package (test.framework.toy_build.ToyBuildTest)
Test use of --package and accompanying package configuration settings.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/toy_build.py", line 1650, in test_package
    self.assertTrue(os.path.exists(toypkg), "%s is there" % toypkg)
AssertionError: False is not true : /tmp/eb-QaM9DG/eb-nO03Hh/eb-Xb8aYa/pkgs/toy-0.0-eb-4.1.1.dev0.321.foo is there

======================================================================
FAIL: test_package_skip (test.framework.toy_build.ToyBuildTest)
Test use of --package with --skip.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/toy_build.py", line 1665, in test_package_skip
    self.assertTrue(os.path.exists(toypkg), "%s is there" % toypkg)
AssertionError: False is not true : /tmp/eb-QaM9DG/eb-nO03Hh/eb-jUyHlc/packages/toy-0.0-eb-4.1.1.dev0.1.rpm is there

======================================================================
FAIL: test_active_pns (test.framework.package.PackageTest)
Test use of ActivePNS.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/package.py", line 193, in test_active_pns
    self.assertEqual(pns.version(ec), 'eb-%s' % EASYBUILD_VERSION)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/base/testing.py", line 115, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: '4.1.1.dev0~eb' != 'eb-4.1.1.dev0':
DIFF:
- 4.1.1.dev0~eb?           ---
+ eb-4.1.1.dev0

----------------------------------------------------------------------
Ran 680 tests in 634.464s

FAILED (failures=3, errors=1)
ERROR: Not all tests were successful.
Log available at /tmp/eb-QaM9DG/eb-nO03Hh/easybuild-tests-bir1Os.log
travis_time:end:02602088:start=1579095668929161507,finish=1579096303969465793,duration=635040304286,event=script
�[0K�[32;1mThe command "python -O -m test.framework.suite 2>&1 | tee test_framework_suite.log" exited with 0.�[0m
travis_time:start:06cd1dbd
�[0K$ IGNORE_PATTERNS="no GitHub token available|skipping SvnRepository test|lib/python2.6/site-packages|requires Lmod as modules tool"
travis_time:end:06cd1dbd:start=1579096303973276494,finish=1579096303975650760,duration=2374266,event=script
�[0K�[32;1mThe command "IGNORE_PATTERNS="no GitHub token available|skipping SvnRepository test|lib/python2.6/site-packages|requires Lmod as modules tool"" exited with 0.�[0m
travis_time:start:0645ddf8
�[0K$ PRINTED_MSG=$(egrep -v "${IGNORE_PATTERNS}" test_framework_suite.log | grep '\.\n*[A-Za-z]' || true)
travis_time:end:0645ddf8:start=1579096303978867935,finish=1579096303984465943,duration=5598008,event=script
�[0K�[32;1mThe command "PRINTED_MSG=$(egrep -v "${IGNORE_PATTERNS}" test_framework_suite.log | grep '\.\n*[A-Za-z]' || true)" exited with 0.�[0m
travis_time:start:11a2b88a
�[0K$ test "x$PRINTED_MSG" = "x" || (echo "Found printed messages in output of test suite\n${PRINTED_MSG}" && exit 1)
Found printed messages in output of test suite\n.........................................................FF.......................................................................................................................F..E..........................................
ERROR: test_package (test.framework.package.PackageTest)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/package.py", line 228, in test_package
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/tools/filetools.py", line 191, in read_file
EasyBuildError: "Failed to read /tmp/eb-QaM9DG/eb-nO03Hh/eb-o1_tgh/eb-OjF3AO/eb-5G10RS/eb-pkgs-9PZqO1/toy-0.0-gompi-2018a-test-eb-4.1.1.dev0.1.rpm: [Errno 2] No such file or directory: '/tmp/eb-QaM9DG/eb-nO03Hh/eb-o1_tgh/eb-OjF3AO/eb-5G10RS/eb-pkgs-9PZqO1/toy-0.0-gompi-2018a-test-eb-4.1.1.dev0.1.rpm'"
FAIL: test_package (test.framework.toy_build.ToyBuildTest)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/toy_build.py", line 1650, in test_package
    self.assertTrue(os.path.exists(toypkg), "%s is there" % toypkg)
AssertionError: False is not true : /tmp/eb-QaM9DG/eb-nO03Hh/eb-Xb8aYa/pkgs/toy-0.0-eb-4.1.1.dev0.321.foo is there
FAIL: test_package_skip (test.framework.toy_build.ToyBuildTest)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/toy_build.py", line 1665, in test_package_skip
    self.assertTrue(os.path.exists(toypkg), "%s is there" % toypkg)
AssertionError: False is not true : /tmp/eb-QaM9DG/eb-nO03Hh/eb-jUyHlc/packages/toy-0.0-eb-4.1.1.dev0.1.rpm is there
FAIL: test_active_pns (test.framework.package.PackageTest)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/test/framework/package.py", line 193, in test_active_pns
    self.assertEqual(pns.version(ec), 'eb-%s' % EASYBUILD_VERSION)
  File "/tmp/637435168/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/base/testing.py", line 115, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: '4.1.1.dev0~eb' != 'eb-4.1.1.dev0':
- 4.1.1.dev0~eb?           ---
+ eb-4.1.1.dev0
Log available at /tmp/eb-QaM9DG/eb-nO03Hh/easybuild-tests-bir1Os.log

• 3788.2 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435169
• 3788.3 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435170
• 3788.4 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435171
• 3788.5 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435172
• 3788.6 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435173
• 3788.7 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435174
• 3788.8 - failed => https://travis-ci.org/easybuilders/easybuild-framework/jobs/637435175

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

[akesandgren]

What you should do is add a timestamp after the ~eb, as in ~eb-yyyymmdd to make it possible to update the eb built package automatically. Using the date_stamp = datetime.today().strftime('%Y%m%d') code from the first commit.