Skip to content

Pizza flavor question for registration page #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions common/src/input/pizza-flavor.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { z } from "zod/v4"
import { recordEntries } from "@/util/record-entries"

export const pizzaFlavorSchema = z.enum(["nothing", "alternative", "margherita", "pepperoni"])

export type PizzaFlavor = z.output<typeof pizzaFlavorSchema>

const PizzaFlavourMetadata: Record<PizzaFlavor, { label: string }> = {
nothing: { label: "Nothing" },
alternative: { label: "Alternative" },
margherita: { label: "Margherita" },
pepperoni: { label: "Pepperoni" },
}

export const pizzaFlavourOptions = recordEntries(PizzaFlavourMetadata).map(([value, metadata]) => ({
value,
label: metadata.label,
})) satisfies Array<{
value: PizzaFlavor
label: string
}>
2 changes: 2 additions & 0 deletions common/src/types/application.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { DisciplineOfStudy } from "@/input/discipline-of-study"
import type { DietaryRequirement } from "@/input/dietary-requirement"
import { PizzaFlavor } from "@/input/pizza-flavor";

export type { DisciplineOfStudy, DietaryRequirement }

Expand All @@ -23,6 +24,7 @@ export type Application = {
university: string | null
graduationYear: number | null
disciplinesOfStudy: null | DisciplineOfStudy[]
pizzaFlavors: null | PizzaFlavor[]
levelOfStudy:
| null
| "secondary"
Expand Down
22 changes: 22 additions & 0 deletions server/src/routes/application/application-handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import assert from "node:assert/strict"
import { parse as parsePath } from "node:path/posix"
import { type DietaryRequirement, dietaryRequirementSchema } from "@durhack/durhack-common/input/dietary-requirement"
import { type DisciplineOfStudy, disciplineOfStudySchema } from "@durhack/durhack-common/input/discipline-of-study"
import { type PizzaFlavor, pizzaFlavorSchema } from "@durhack/durhack-common/input/pizza-flavor"
import type { Application } from "@durhack/durhack-common/types/application"
import { ClientError, HttpStatus } from "@otterhttp/errors"
import type { ContentType, ParsedFormFieldFile } from "@otterhttp/parsec"
Expand Down Expand Up @@ -49,6 +50,13 @@ const personalFormSchema = z.object({
message: "Please select an ethnicity",
})
.transform(adaptEthnicityToDatabase),
pizza: z
.array(pizzaFlavorSchema)
.min(1, { message: "Please select at least one pizza flavor." })
.refine((list) => {
const mutuallyExclusivePreferences = list.filter((item) => item === "alternative" || item === "nothing")
return mutuallyExclusivePreferences.length <= 1
}, "If you don't want pizza, please choose one of 'nothing' or 'alternative'."),
})

const contactFormSchema = z.object({
Expand Down Expand Up @@ -154,6 +162,9 @@ class ApplicationHandlers {
const dietaryRequirements = userFlags
.filter((flag) => flag.flagName.startsWith("dietary-requirement:"))
.map((flag) => flag.flagName.slice(20) as DietaryRequirement)
const pizzaFlavors = userFlags
.filter((flag) => flag.flagName.startsWith("pizza-flavor:"))
.map((flag) => flag.flagName.slice(13) as PizzaFlavor)

const {
phone_number,
Expand Down Expand Up @@ -190,6 +201,7 @@ class ApplicationHandlers {
disciplinesOfStudy: disciplinesOfStudy,
tShirtSize: (userInfo?.tShirtSize?.trimEnd() as Application["tShirtSize"] | null | undefined) ?? null,
dietaryRequirements: dietaryRequirements,
pizzaFlavors: pizzaFlavors,
accessRequirements: userInfo?.accessRequirements ?? null,
countryOfResidence: userInfo?.countryOfResidence ?? null,
consents: userConsents.map((consent) => ({ name: consent.consentName, choice: consent.choice })),
Expand Down Expand Up @@ -633,6 +645,16 @@ class ApplicationHandlers {
response.sendStatus(200)
}
}

@onlyKnownUsers()
patchPizza(): Middleware {
return async (request, _response) => {
const { user } = request
assert(user)

// Do some magic here
}
}
}

const applicationHandlers = new ApplicationHandlers()
Expand Down