Skip to content

feat(server) : add logs to investigate test_take_over_seeder #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adiholden
Copy link
Collaborator

@adiholden adiholden commented Jul 1, 2025

Increase log verbosity to debug the failing test.

@adiholden adiholden requested review from mkaruza and BorysTheDev July 1, 2025 12:11
kostasrim
kostasrim previously approved these changes Jul 1, 2025
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you can also edit the CI flow to run this test in a loop without merging and it will be probably be faster to iterate on it.

Otherwise, LGTM

@mkaruza
Copy link
Contributor

mkaruza commented Jul 1, 2025

Pushed commit to test only regression-test with (ubuntu-dev:20, Uring, Debug, ubuntu-latest) matrix where test fails

adiholden and others added 2 commits July 2, 2025 08:39
Signed-off-by: adi_holden <adi@dragonflydb.io>
Test fails on regression-test on (ubuntu-dev:20, Uring, Debug,
ubuntu-latest) so select only that matrix to run.

Signed-off-by: mkaruza <mario@dragonflydb.io>
@mkaruza mkaruza force-pushed the test_take_over_seeder branch from 87b6516 to 3c59f4a Compare July 2, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants