-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feat config management #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat config management #5388
Conversation
…mpatibility - Output process_id (PID) in the INFO SERVER section, matching Redis order and naming. - Use getpid() and ensure <unistd.h> is included for portability.
…FO SERVER enhancement
…FO SERVER enhancement
Hey @romange , Roman here! I'm back again 😅 First off, I really appreciate your patience with my PR—sorry for the extra time spent on details. But I couldn't resist swinging by to chip in a little more for the project! 😄 |
Thank you @boomballa 🙏🏼 |
Co-authored-by: Roman Gershman <romange@gmail.com> Signed-off-by: boomballa <boomballa0418@gmail.com>
Hey @romange , thanks a bunch! With your suggestions and edits, this PR has become so much more concise. Really appreciate your help. I’ll be more mindful of code submission standards moving forward. Thanks again! 🙏 |
Hi @boomballa, It looks like we have a crash in the tests. See https://github.com/dragonflydb/dragonfly/actions/runs/15992173518/job/45107833943?pr=5388 trace:
|
Summary
This PR enhances DragonflyDB's
INFO SERVER
output to be more compatible with Redis, by adding several key fields.Features
hz
process_id
executable
config_file
info server
output, for example:Implementation Details
executable
andconfig_file
are set at startup and used for info reporting.hz
is reported using the value of theFLAGS_hz
flag.process_id
is reported usinggetpid()
for portability.CONFIG GET config_file
orCONFIG REWRITE
are included in this PR; those features will be submitted separately.Compatibility
INFO SERVER
section.Checklist
Closes: #3789