chore(tiering): Push error handling one more level up #5351
+90
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
reviewed
Jun 27, 2025
| @@ -180,7 +177,7 @@ OpResult<TResult<size_t>> OpStrLen(const OpArgs& op_args, string_view key) { | |||
| fb2::Future<size_t> fut; | |||
| op_args.shard->tiered_storage()->Read( | |||
| op_args.db_cntx.db_index, key, co, | |||
| [fut](const std::string& s) mutable { fut.Resolve(s.size()); }); | |||
| [fut](io::Result<std::string> s) mutable { fut.Resolve(s->size()); }); | |||
There was a problem hiding this comment.
doesn't that trigger a deep copy of the io::Result which will deep copy the string ?
There was a problem hiding this comment.
I just moved the copy one level up in the call chain. I also left a small todo in the place of invocation, as passing it by value will make it possible to move the last value
|
@romange I pulled romange/helio#422 with me, which fails in some replication cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error types to OpManager and TieredStorage. Next PR will focus on string family and other tiering users. Pull helio