chore: prefetch keys in opmget #4778
Open
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Prefetch
branch
2 times, most recently
from
2ae1ba8 to
e01e062
Compare
romange
force-pushed
the
Prefetch
branch
4 times, most recently
from
6336ef0 to
4084072
Compare
BorysTheDev
approved these changes
Mar 17, 2025
BorysTheDev
reviewed
Mar 17, 2025
Comment on lines
+572
to
+581
| constexpr unsigned kPrefetchLimit = 32; | ||
| if (mget_prefetch_keys) { | ||
| unsigned prefetched = 0; | ||
| for (string_view key : keys) { | ||
| pt.Prefetch(key); | ||
| if (++prefetched >= kPrefetchLimit) { | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we move it before key_index.reserve() or even higher to have more time for memory prefetching?
dranikpg
reviewed
Apr 8, 2025
Hello 👨🍳 |
romange
force-pushed
the
Prefetch
branch
2 times, most recently
from
6ce9934 to
3704a3f
Compare
Also, stop deduplicating keys by default, but keep it as a run-time flag. All in all, this PR improves MGET (100% miss) throughput by at least 7%: from 1.23M to 1.32M qps. (100% miss traffic allows measuring more effectively the impact of this code) Also, finally fix TieredStorageTest.FlushAll test. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, stop deduplicating keys by default, but keep it as a run-time flag.
All in all, this PR improves MGET (100% miss) throughput by at least 7%:
from 1.23M to 1.32M qps.
(100% miss traffic allows measuring more effectively the impact of this code)
Also, finally fix TieredStorageTest.FlushAll test.