Skip to content

bump CBMC to version 6 #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cbmc
Submodule cbmc updated 255 files
6 changes: 3 additions & 3 deletions regression/verilog/case/case3.v
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ module main(input clk, x, y);

always @(posedge clk)
casez (cnt1)
{10'b0z, 2'b00}:;
{10'b0z, 2'b01}:;
{10'b0z, 2'b1z}: out=1;
10'b0z00:;
10'b0z01:;
10'b0z1z: out=1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see the earlier failures, but why is it that changes to the tests are the right fix here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bigger project to do the right thing. Will get on it.

endcase

always assert p1: out==0;
Expand Down
2 changes: 1 addition & 1 deletion regression/verilog/case/case4.v
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module m(input [7:0] i, output reg [31:0] x);
casex(i)
8'b1x: x=1;
8'bxx: x=2;
{ 'b11, 'bx, 'bx }: x=3;
8'b11xx: x=3;
default: x=4;
endcase

Expand Down
3 changes: 1 addition & 2 deletions src/smvlang/smv_language.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ bool smv_languaget::parse(
const std::string &path,
message_handlert &message_handler)
{
smv_parsert smv_parser;
smv_parsert smv_parser(message_handler);

const std::string main_name=smv_module_symbol("main");
smv_parser.module=&smv_parser.parse_tree.modules[main_name];
Expand All @@ -41,7 +41,6 @@ bool smv_languaget::parse(

smv_parser.set_file(path);
smv_parser.in=&instream;
smv_parser.log.set_message_handler(message_handler);

bool result=smv_parser.parse();

Expand Down
3 changes: 2 additions & 1 deletion src/smvlang/smv_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ extern class smv_parsert *smv_parser_ptr;
class smv_parsert:public parsert
{
public:
smv_parsert()
explicit smv_parsert(message_handlert &message_handler)
: parsert(message_handler)
{
PRECONDITION(smv_parser_ptr == nullptr);
smv_parser_ptr = this;
Expand Down
6 changes: 2 additions & 4 deletions src/verilog/verilog_language.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,10 @@ bool verilog_languaget::parse(
else
standard = verilog_standardt::V2005_SMV;

verilog_parsert verilog_parser(standard);
verilog_parsert verilog_parser(standard, message_handler);

verilog_parser.set_file(path);
verilog_parser.in=&str;
verilog_parser.log.set_message_handler(message_handler);
verilog_parser.grammar=verilog_parsert::LANGUAGE;

verilog_scanner_init();
Expand Down Expand Up @@ -297,11 +296,10 @@ bool verilog_languaget::to_expr(
verilog_standardt standard = verilog_standardt::V2005;

// parsing
verilog_parsert verilog_parser(standard);
verilog_parsert verilog_parser(standard, message_handler);

verilog_parser.set_file("");
verilog_parser.in=&i_preprocessed;
verilog_parser.log.set_message_handler(message_handler);
verilog_parser.grammar=verilog_parsert::EXPRESSION;
verilog_scanner_init();

Expand Down
3 changes: 1 addition & 2 deletions src/verilog/verilog_parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,9 @@ bool parse_verilog_file(const std::string &filename, verilog_standardt standard)
std::ifstream in(widen_if_needed(filename));
console_message_handlert console_message_handler;

verilog_parsert verilog_parser(standard);
verilog_parsert verilog_parser(standard, console_message_handler);

verilog_parser.set_file(filename);
verilog_parser.log.set_message_handler(console_message_handler);

if(filename=="")
verilog_parser.in=&std::cin;
Expand Down
5 changes: 4 additions & 1 deletion src/verilog/verilog_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ class verilog_parsert:public parsert
return yyverilogparse()!=0;
}

explicit verilog_parsert(verilog_standardt standard) : parse_tree(standard)
explicit verilog_parsert(
verilog_standardt standard,
message_handlert &message_handler)
: parsert(message_handler), parse_tree(standard)
{
PRECONDITION(verilog_parser_ptr == nullptr);
verilog_parser_ptr = this;
Expand Down
8 changes: 1 addition & 7 deletions src/vhdl/parser.y
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,7 @@ int yyvhdlerror(const char *error_str)
tmp+='\'';
}

source_locationt source_location;
source_location.set_column(yyvhdllval.column);
source_location.set_line(yyvhdllval.line);
source_location.set_file(yyvhdllval.file);

PARSER.log.error().source_location=source_location;
PARSER.log.error() << tmp << messaget::eom;
PARSER.parse_error(error_str, yyvhdltext);

return strlen(error_str)+1;
}
Expand Down
6 changes: 2 additions & 4 deletions src/vhdl/vhdl_language.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,10 @@ bool vhdl_languaget::parse(
const std::string &path,
message_handlert &message_handler)
{
vhdl_parsert vhdl_parser;
vhdl_parsert vhdl_parser(message_handler);

vhdl_parser.set_file(path);
vhdl_parser.in=&instream;
vhdl_parser.log.set_message_handler(message_handler);
//vhdl_parser.grammar=vhdl_parsert::LANGUAGE;

vhdl_scanner_init();
Expand Down Expand Up @@ -270,10 +269,9 @@ bool vhdl_languaget::to_expr(
std::istringstream i_preprocessed(code);

// parsing
vhdl_parsert vhdl_parser;
vhdl_parsert vhdl_parser(message_handler);
vhdl_parser.set_file("");
vhdl_parser.in=&i_preprocessed;
vhdl_parser.log.set_message_handler(message_handler);
vhdl_parser.grammar=vhdl_parsert::EXPRESSION;
vhdl_scanner_init();

Expand Down
3 changes: 1 addition & 2 deletions src/vhdl/vhdl_parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ bool parse_vhdl_file(const std::string &filename)
std::ifstream in(widen_if_needed(filename));
console_message_handlert console_message_handler;

vhdl_parsert vhdl_parser;
vhdl_parsert vhdl_parser(console_message_handler);
vhdl_parser.set_file(filename);
vhdl_parser.log.set_message_handler(console_message_handler);

if(filename=="")
vhdl_parser.in=&std::cin;
Expand Down
3 changes: 2 additions & 1 deletion src/vhdl/vhdl_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ class vhdl_parsert:public parsert
return yyvhdlparse();
}

vhdl_parsert()
explicit vhdl_parsert(message_handlert &message_handler)
: parsert(message_handler)
{
PRECONDITION(vhdl_parser_ptr == nullptr);
vhdl_parser_ptr = this;
Expand Down