Skip to content

[Devfile #1718] Dynamic paths for devfile tests #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JslYoon
Copy link

@JslYoon JslYoon commented Jul 17, 2025

Description of Changes

Added dynamic path to take in different data paths for tests check_odov3.sh, check_non_terminating.sh, and validate_devfile_schemas.sh as per changes to be made for epic devfile/api#1278

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

devfile/api#1718

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@JslYoon JslYoon requested a review from michael-valdron July 17, 2025 19:31
@JslYoon JslYoon requested a review from a team as a code owner July 17, 2025 19:31
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk July 17, 2025 19:31
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address DCO use git commit -s to sign off your commits, you can fix your current commit running: git commit -s --amend && git push -f

I'll ignore the Konflux failure as this is not applicable with a deployment change and I'm working on fixing that currently to unblock all promotion changes as they come.

Copy link

openshift-ci bot commented Jul 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JslYoon
Once this PR has been reviewed and has the lgtm label, please ask for approval from michael-valdron. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop and logic for setting the stackDirs and stacksPath looks identical in check_non_terminating.sh and check_odov3, and is pretty similar in validate_devfile_schemas though I see it has more cases. Is there any way we can consolidate some of this so we don't need to change things in multiple places in the future?

If it isn't possible lmk

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the JslYoon-renovate-tests branch from 177db2b to 004f49c Compare July 18, 2025 15:23
@JslYoon JslYoon requested a review from Jdubrick July 18, 2025 15:39
@JslYoon
Copy link
Author

JslYoon commented Jul 18, 2025

@Jdubrick just made the changes!

@JslYoon JslYoon requested a review from michael-valdron July 18, 2025 15:39
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the JslYoon-renovate-tests branch from 34342cf to 39e2d9d Compare July 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants