Skip to content

Farabi/grwt-5822/fix-inconsistent-header #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farabi-deriv
Copy link
Contributor

This pull request introduces updates to the header styling and layout in both SCSS and JSX files. The changes aim to improve the header's visual spacing, alignment, and functionality, including adjustments to margins, padding, and the order of menu items.

Styling adjustments in src/sass/_common/header.scss:

  • Reduced margin-left from 8px to 4px for elements within the header to improve alignment.
  • Increased padding for menu links from 0 8px to 0 16px and added specific padding for .url-appstore.
  • Added margin: 0 8px to the &__expand class for better spacing consistency.
  • Changed margin-right: 10px to margin: 0 10px for the &__notification class to standardize margin behavior.

Layout updates in src/templates/_common/_layout/header.jsx:

  • Removed the mobile-hide class from the header-menu-links client_logged_in div to make it visible across devices.
  • Corrected text capitalization in the label for "Trader's Hub."
  • Reorganized header menu items, including moving "Reports" back into the menu and adjusting the placement of the "Deposit" button.
  • Restored the Notification component and the "Account Details" link in the header's menu-right section.

@farabi-deriv farabi-deriv requested a review from a team as a code owner July 11, 2025 10:30
@farabi-deriv farabi-deriv deployed to Development July 11, 2025 10:30 — with GitHub Actions Active
Copy link

Preview Link: https://pr-1168.smarttrader-preview.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant