Release 4.0.0 rc.1 #486
Release 4.0.0 rc.1 #486
Conversation
MarkWolters
requested review from
jshook,
jkni,
tlwillke,
marianotepper and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 4.0.0 release candidate by bumping the project version and switching the multirelease module to use Sonatype Central for snapshot and staging deployments.
- Bump
<revision>to4.0.0-rc.2-SNAPSHOT - Replace OSSRH snapshot endpoint with Central snapshots and add staging repository
- Update Nexus staging plugin
serverIdandnexusUrlto Central
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Updated <revision> to rc.2-SNAPSHOT for the upcoming release candidate |
| jvector-multirelease/pom.xml | Switched snapshot repo to Central URLs, added staging repo, and updated plugin config |
Comments suppressed due to low confidence (1)
jvector-multirelease/pom.xml:20
- [nitpick] Indentation is inconsistent for this tag (appears to use a tab); aligning it with the rest of the XML using spaces will improve readability and maintain consistency.
<url>https://central.sonatype.com/content/repositories/snapshots</url>
| @@ -41,7 +41,7 @@ | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <maven.install.skip>true</maven.install.skip> | |||
| <revision>4.0.0-beta.6-SNAPSHOT</revision> | |||
| <revision>4.0.0-rc.2-SNAPSHOT</revision> | |||
There was a problem hiding this comment.
[nitpick] The revision property has been updated to rc.2-SNAPSHOT but the PR title references rc.1; consider aligning the version or updating the PR title to avoid confusion.
Copilot uses AI. Check for mistakes.
| @@ -146,8 +150,8 @@ | |||
| </execution> | |||
| </executions> | |||
| <configuration> | |||
| <serverId>ossrh</serverId> | |||
| <nexusUrl>https://s01.oss.sonatype.org/</nexusUrl> | |||
| <serverId>central</serverId> | |||
There was a problem hiding this comment.
Using a generic serverId 'central' for both snapshot and release deployments may conflict with Maven's default repository; consider using distinct, descriptive IDs (e.g., sonatype-snapshots and sonatype-staging) and update settings.xml accordingly.
| <serverId>central</serverId> | |
| <serverId>sonatype-staging</serverId> |
Copilot uses AI. Check for mistakes.
|
We should add a changelog |
No description provided.