Skip to content

Update filmic-rgb.md #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dave22152
Copy link
Contributor

This is in response to Document recent changes to filmic defaults, #527

I updated references to changed defaults and changed the structure to the mid tone saturation controls to emphasize the newer v6 and 7 versions

This is my first attempt at a Pull Request, so hopefully I did this correctly.

Updated references to changed defaults and changed the structure to the mid tone saturation controls to emphasize the newer v6 and 7 versions
@@ -212,19 +212,19 @@ hardness (previously _target power factor function_)
: This parameter is the power function applied to the output transfer function, and it is often improperly called the _gamma_ (which can mean too many things in imaging applications, so we should stop using that term). It is used to raise or compress the mid-tones to account for display non-linearities or to avoid quantization artifacts when encoding in 8 bit file formats. This is a common operation when applying ICC color profiles (except for linear RGB spaces, like Rec. 709 or Rec. 2020, which have a linear “gamma” of 1.0). However, at the output of _filmic rgb_, the signal is logarithmically encoded, which is not something ICC color profiles know to handle. As a consequence, if we let them apply a gamma of 1/2.2 on top, it will result in a double-up, which would cause the middle-gray to be remapped to 76% instead of 45% as it should in display-referred space.

latitude
: The latitude is the range between the two nodes enclosing the central linear portion of the curve, expressed as a percentage of the dynamic range defined in the [_scene_](#scene) tab (white relative exposure minus black relative exposure). It is the luminance range that is remapped in priority, and it is remapped to the luminance interval defined by the contrast parameter. It is usually advisable to keep the latitude as large as possible, while avoiding clipping. If clipping is observed, you can compensate by either decreasing the latitude, shifting the latitude interval with the _shadow ↔ highlights balance_ parameter, or decreasing the contrast.
: The latitude is the range between the two nodes enclosing the central linear portion of the curve, expressed as a percentage of the dynamic range defined in the [_scene_](#scene) tab (white relative exposure minus black relative exposure). It is the luminance range that is remapped in priority, and it is remapped to the luminance interval defined by the contrast parameter. While it is set to 0 by default, it is usually advisable to keep the latitude as large as possible, while avoiding clipping. If clipping is observed, you can compensate by either decreasing the latitude, shifting the latitude interval with the _shadow ↔ highlights balance_ parameter, or decreasing the contrast.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed all of the text in the PR but this paragraph is the reason I haven't resolved that issue so far. The recommendation (keep the latitude large) comes from the original developer. But since he is also the person who changed the default value to 0, it's hard to justify keeping that recommendation. Unfortunately since he's stopped talking to anyone involved in darktable now, it's hard to resolve this contradiction or understand his reasoning for the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the least worst option might be to just remove reference to the recommendation altogether

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is a contradiction. I believe it makes sense to set the latitude as wide a possible to control the roll-off at the edges, but the default is set at zero so the user can decide the settings to use. At least, that's how I see it. Personally, I don't bother with latitude, so I'm ok with the change or to remove that discussion altogether.

Copy link

github-actions bot commented Jun 5, 2025

This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No activity on this PR label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No activity on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants