Add protection against corrupted embedded ICC profile #18977
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
approved these changes
Jun 22, 2025
TurboGit
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds crash protection in a situation where we read an embedded ICC profile from an image file, but it is corrupted to the point that lcms2 cannot open it as a profile.
Never seen this in the wild, it's more of a theoretical possibility (after all, although this is an extremely rare story, bit rot is possible).
To test this PR, you can download the file m1-3c6b71d657852e13d0b5dfc0906343f5.tif from gimp-test-images testset. After this PR, darktable shows that it cannot read the file, but does not crash.