Skip to content

RFC(?): Hide rotate pixels module in the modules panel #18926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RFC(?): Hide rotate pixels module in the modules panel #18926

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d266e48
Hide rotate pixels module in the modules panel
victoryforce Jun 5, 2025
0fae1ce
Remove all GUI related code
victoryforce Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions src/iop/rotatepixels.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const char *name()
int flags()
{
return IOP_FLAGS_ALLOW_TILING | IOP_FLAGS_TILING_FULL_ROI | IOP_FLAGS_ONE_INSTANCE
| IOP_FLAGS_UNSAFE_COPY;
| IOP_FLAGS_UNSAFE_COPY | IOP_FLAGS_HIDDEN;
}

int default_group()
Expand Down Expand Up @@ -349,31 +349,10 @@ void reload_defaults(dt_iop_module_t *self)
*d = (dt_iop_rotatepixels_params_t){ .rx = 0u, .ry = image->fuji_rotation_pos, .angle = -45.0f };

self->default_enabled = ((d->rx != 0u) || (d->ry != 0u));

// FIXME: does not work.
self->hide_enable_button = !self->default_enabled;

if(self->widget)
gtk_label_set_text(GTK_LABEL(self->widget), self->default_enabled
? _("automatic pixel rotation")
: _("automatic pixel rotation\nonly works for the sensors that need it."));
}

void gui_update(dt_iop_module_t *self)
{
}
void gui_init(dt_iop_module_t *self)
{
IOP_GUI_ALLOC(rotatepixels);

self->widget = dt_ui_label_new("");
gtk_label_set_line_wrap(GTK_LABEL(self->widget), TRUE);

}

// clang-format off
// modelines: These editor modelines have been set for all relevant files by tools/update_modelines.py
// vim: shiftwidth=2 expandtab tabstop=2 cindent
// kate: tab-indents: off; indent-width 2; replace-tabs on; indent-mode cstyle; remove-trailing-spaces modified;
// clang-format on

Loading