[imageio] Update QOI format implementation code from upstream #18917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tree from upstream
|
This seems ultra safe and QOI is not a widely used format, yet I'm not sure we should have this late in 5.2 release cycle. What's your take @victoryforce? |
|
The decoding speedup due to the faster operation (maybe around 1%) is too small to be noticeable. So it's perfectly OK to leave this change for the 5.4 release cycle. OTOH, I don't see any danger of introducing bugs, since for unsigned integers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the single-header implementation of QOI format (we use an upstream copy in our source tree) to the current version. The author of the upstream enhancement claims that it makes QOI encoding 1.4% faster by replacing modulo with mask. We don't use encoding because we don't export to that format, but an identical change was made to the decoding code as well, so we can expect decoding to be faster by a comparable amount.