Skip to content

darktable.c: logdir in cli help #17975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2024
Merged

darktable.c: logdir in cli help #17975

merged 1 commit into from
Dec 14, 2024

Conversation

esq4
Copy link
Contributor

@esq4 esq4 commented Dec 9, 2024 •
edited
Loading

addition to 864923d

kmilos
kmilos reviewed Dec 9, 2024
View reviewed changes
@esq4
Copy link
Contributor Author

esq4 commented Dec 9, 2024

Since during installation the default destination folder is in lowercase, might it be more correct to make these directories the same?
Although I made a change to this PR.

darktable

@kmilos
Copy link
Contributor

kmilos commented Dec 9, 2024 •
edited
Loading

Since during installation the default destination folder is in lowercase, might it be more correct to make these directories the same?

I'm afraid that ship has sailed - we already create "Pictures\Darktable" for years as @victoryforce already mentioned (I actually tried changing to lowercase long time ago but there was no interest), and now we have "Documents\Darktable".

@esq4
Copy link
Contributor Author

esq4 commented Dec 9, 2024

It's clear.

@victoryforce victoryforce added this to the 5.0 milestone Dec 14, 2024
@victoryforce
Copy link
Collaborator

@TurboGit This PR corrects the oversight that the change of the logging directory was not reflected in the information provided by --help. We definitely don't want the usage text to show the wrong location.

TurboGit
TurboGit approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine by me and thanks @victoryforce to ping me about this.

@TurboGit TurboGit merged commit 7c980ff into darktable-org:master Dec 14, 2024
6 checks passed
@TurboGit TurboGit added bugfix pull request fixing a bug scope: windows support windows related issues and PR labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos left review comments

@victoryforce victoryforce victoryforce left review comments

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug scope: windows support windows related issues and PR
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@esq4 @kmilos @victoryforce @TurboGit