Skip to content

close splash screen by yes/no dialog #17725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Oct 26, 2024

It seems that setting the yes/no dialog as the topmost window (#17688) is not sufficient on some systems.

To be on the safe side we close the splash screen when the yes/no dialog pops up.

fixes #17719

It seems that setting the yes/no dialog as the topmost window (darktable-org#17688)
is not sufficient on some systems.

To be on the safe side we close the splash screen when the yes/no dialog
pops up.

fixes darktable-org#17719
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit added this to the 5.0 milestone Oct 27, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug understood: unclear devs lack most or all important info and can do nothing, the report will be closed after 2 weeks labels Oct 27, 2024
@TurboGit TurboGit merged commit f804b68 into darktable-org:master Oct 27, 2024
6 checks passed
@zisoft zisoft deleted the close-splash branch October 27, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug understood: unclear devs lack most or all important info and can do nothing, the report will be closed after 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The splash screen almost perfectly hides upgrade dialog
2 participants